You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/08/03 18:36:54 UTC
Review Request 37042: LENS-708 : Improve "how to commit" doc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
https://issues.apache.org/jira/browse/LENS-708
Committer doc fixes.
Diffs
-----
pom.xml 3c98077
src/site/apt/developer/commit.apt 6982ead
Diff: https://reviews.apache.org/r/37042/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 4, 2015, 1:49 a.m., Raju Bairishetti wrote:
> > src/site/apt/developer/commit.apt, line 136
> > <https://reviews.apache.org/r/37042/diff/2/?file=1027733#file1027733line136>
> >
> > Can we use **git revert \<commit id>** instead of relative commit position from the latest position?
> >
> > Some times we may want to revert older commits also. Then it will be easy to revert with commit id instead of relative from HEAD positions.
Can we add both?
Since 1st commit might only be couple of commits back ?
> On Aug. 4, 2015, 1:49 a.m., Raju Bairishetti wrote:
> > src/site/apt/developer/commit.apt, line 96
> > <https://reviews.apache.org/r/37042/diff/2/?file=1027733#file1027733line96>
> >
> > Can we include "-a" also in the command?
Makes sense
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review93989
-----------------------------------------------------------
On Aug. 3, 2015, 6:03 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 6:03 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review93989
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 90)
<https://reviews.apache.org/r/37042/#comment148475>
Can we include "-a" also in the command?
src/site/apt/developer/commit.apt (line 130)
<https://reviews.apache.org/r/37042/#comment148474>
Can we use **git revert \<commit id>** instead of relative commit position from the latest position?
Some times we may want to revert older commits also. Then it will be easy to revert with commit id instead of relative from HEAD positions.
- Raju Bairishetti
On Aug. 3, 2015, 6:03 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 6:03 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review93990
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 105)
<https://reviews.apache.org/r/37042/#comment148476>
@yash Can we ask committer to setup user name and email for Lens git repo before making first commit?
git config user.name <name>
git config user.email <email>
- Raju Bairishetti
On Aug. 3, 2015, 6:03 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 6:03 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review94010
-----------------------------------------------------------
pom.xml (line 306)
<https://reviews.apache.org/r/37042/#comment148515>
Please add names in alphabetical order. We were following the same across all names
src/site/apt/developer/commit.apt (line 105)
<https://reviews.apache.org/r/37042/#comment148516>
Can we move this to new committer section above?
- Amareshwari Sriramadasu
On Aug. 3, 2015, 6:03 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 6:03 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review94060
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Aug. 4, 2015, 2:31 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:31 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:31 p.m.)
Review request for lens.
Changes
-------
Implementted new review comments
Repository: lens
Description
-------
https://issues.apache.org/jira/browse/LENS-708
Committer doc fixes.
Diffs (updated)
-----
pom.xml 3c98077
src/site/apt/developer/commit.apt 6982ead
Diff: https://reviews.apache.org/r/37042/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review94043
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 141)
<https://reviews.apache.org/r/37042/#comment148550>
Can be full hash too. Don't need to mention that it's the starting characters.
- Rajat Khandelwal
On Aug. 4, 2015, 3:13 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:13 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 9:43 a.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Repository: lens
Description
-------
https://issues.apache.org/jira/browse/LENS-708
Committer doc fixes.
Diffs (updated)
-----
pom.xml 3c98077
src/site/apt/developer/commit.apt 6982ead
Diff: https://reviews.apache.org/r/37042/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review94009
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Aug. 3, 2015, 11:33 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 11:33 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/#review93993
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 130)
<https://reviews.apache.org/r/37042/#comment148481>
Sure. We can have both.
- Raju Bairishetti
On Aug. 3, 2015, 6:03 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37042/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 6:03 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-708
>
> Committer doc fixes.
>
>
> Diffs
> -----
>
> pom.xml 3c98077
> src/site/apt/developer/commit.apt 6982ead
>
> Diff: https://reviews.apache.org/r/37042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37042: LENS-708 : Improve "how to commit" doc
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37042/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 6:03 p.m.)
Review request for lens.
Changes
-------
Minor formatting.
Repository: lens
Description
-------
https://issues.apache.org/jira/browse/LENS-708
Committer doc fixes.
Diffs (updated)
-----
pom.xml 3c98077
src/site/apt/developer/commit.apt 6982ead
Diff: https://reviews.apache.org/r/37042/diff/
Testing
-------
Thanks,
Yash Sharma