You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by fei long <ca...@gmail.com> on 2019/01/14 03:34:20 UTC
Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Bugs: MESOS-9394
https://issues.apache.org/jira/browse/MESOS-9394
Repository: mesos
Description
-------
Fixed maintenance causes machines not in schedule rescinding offers.
Diffs
-----
src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
Diff: https://reviews.apache.org/r/69735/diff/1/
Testing
-------
Thanks,
fei long
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211943
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69735']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2771/mesos-review-69735
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2771/mesos-review-69735/logs/mesos-tests.log):
```
W0114 04:41:35.420104 18600 slave.cpp:3933] Ignoring shutdown framework 7c700e9f-216a-4e3e-8f70-5993e23dfe89-0000 because it is terminating
I0114 04:41:35.422096 15800 master.cpp:1269] Agent 7c700e9f-216a-4e3e-8f70-5993e23dfe89-S0 at slave(468)@192.10.1.6:58932 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0114 04:41:35.422096 15800 master.cpp:3272] Disconnecting agent 7c700e9f-216a-4e3e-8f70-5993e23dfe89-S0 at slave(468)@192.10.1.6:58932 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0114 04:41:35.422096 15800 master.cpp:3291] Deactivating agent 7c700e9f-216a-4e3e-8f70-5993e23dfe89-S0 at slave(468)@192.10.1.6:58932 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0114 04:41:35.422096 20776 hierarchical.cpp:358] Removed framework 7c700e9f-216a-4e3e-8f70-5993e23dfe89-0000
I0114 04:41:35.423092 20776 hierarchical.cpp:802] Agent 7c700e9f-216a-4e3e-8f70-5993e23dfe89-S0 deactivated
I0114 04:41:35.424093 16456 containerizer.cpp:2469] Destroying container 57b6fd82-e784-4421-bc5b-ca72d593ee2e in RUNNING state
I0114 04:41:35.424093 16456 containerizer.cpp:3136] Transitioning the state of container 57b6fd82-e784-4421-bc5b-ca72d593ee2e from RUNNING to DESTROYING
I0114 04:41:35.425137 16456 launcher.cpp:161] Asked to destroy container 57b6fd82-e784-4421-bc5b-ca72d593ee2e
W0114 04:41:35.426120 18000 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=5248 to peer '192.10.1.6:60744': IO failed with error code: The specified network name is[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (690 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (709 ms total)
[----------] Global test environment tear-down
[==========] 1085 tests from 104 test cases ran. (507682 ms total)
[ PASSED ] 1084 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
no longer available.
W0114 04:41:35.426120 18000 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5492 to peer '192.10.1.6:60745': IO failed with error code: The specified network name is no longer available.
I0114 04:41:35.507959 15800 containerizer.cpp:2975] Container 57b6fd82-e784-4421-bc5b-ca72d593ee2e has exited
I0114 04:41:35.538998 18688 master.cpp:1109] Master terminating
I0114 04:41:35.540050 15800 hierarchical.cpp:644] Removed agent 7c700e9f-216a-4e3e-8f70-5993e23dfe89-S0
I0114 04:41:35.915036 18000 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 14, 2019, 3:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 3:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 14, 2019, 7:52 p.m., Joseph Wu wrote:
> > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/
> > The patch is a bit old, but could be re-used if necessary.
>
> fei long wrote:
> Since your patch has not been merged, I copied your code and passed the test by running "./bin/mesos-tests.sh --verbose --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100".
>
> fei long wrote:
> How could I re-trigger the CI?
This requires special Jenkins karma. I triggered a rebuild for you.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211959
-----------------------------------------------------------
On Jan. 14, 2019, 4:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 4:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by fei long <ca...@gmail.com>.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote:
> > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/
> > The patch is a bit old, but could be re-used if necessary.
>
> fei long wrote:
> Since your patch has not been merged, I copied your code and passed the test by running "./bin/mesos-tests.sh --verbose --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100".
>
> fei long wrote:
> How could I re-trigger the CI?
>
> Benjamin Bannier wrote:
> This requires special Jenkins karma. I triggered a rebuild for you.
Thanks! And where can I see the rebuild results...?
- fei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211959
-----------------------------------------------------------
On Jan. 14, 2019, 3:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 3:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by fei long <ca...@gmail.com>.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote:
> > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/
> > The patch is a bit old, but could be re-used if necessary.
>
> fei long wrote:
> Since your patch has not been merged, I copied your code and passed the test by running "./bin/mesos-tests.sh --verbose --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100".
How could I re-trigger the CI?
- fei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211959
-----------------------------------------------------------
On Jan. 14, 2019, 3:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 3:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by fei long <ca...@gmail.com>.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote:
> > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/
> > The patch is a bit old, but could be re-used if necessary.
Since your patch has not been merged, I copied your code and passed the test by running "./bin/mesos-tests.sh --verbose --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100".
- fei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211959
-----------------------------------------------------------
On Jan. 14, 2019, 3:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 3:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211959
-----------------------------------------------------------
Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/
The patch is a bit old, but could be re-used if necessary.
- Joseph Wu
On Jan. 13, 2019, 7:34 p.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2019, 7:34 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by fei long <ca...@gmail.com>.
> On Jan. 14, 2019, 8:57 a.m., Gilbert Song wrote:
> > Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure releted to the change?
I run "./bin/mesos-tests.sh --verbose --gtest_filter="*OperationUpdatesUponAgentGone*" --gtest_break_on_failure --gtest_repeat=100" locally and it passed. I believe it's caused by something else.
- fei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211948
-----------------------------------------------------------
On Jan. 14, 2019, 3:34 a.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 3:34 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>
Re: Review Request 69735: Fixed maintenance causes machines not in
schedule rescinding offers.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69735/#review211948
-----------------------------------------------------------
Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure releted to the change?
- Gilbert Song
On Jan. 13, 2019, 7:34 p.m., fei long wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69735/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2019, 7:34 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9394
> https://issues.apache.org/jira/browse/MESOS-9394
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed maintenance causes machines not in schedule rescinding offers.
>
>
> Diffs
> -----
>
> src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
>
>
> Diff: https://reviews.apache.org/r/69735/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> fei long
>
>