You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/20 00:23:02 UTC

[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #24: [Flink-29895] Migrate integration tests to unit tests and improve unit test coverage

hlteoh37 opened a new pull request, #24:
URL: https://github.com/apache/flink-connector-aws/pull/24

   ## What is the purpose of the change
   - Migrate some integration tests to unit tests
   - Improve unit test coverage.
   
   ## Verifying this change
   - Build locally and verified unit tests and integ tests pass.
   - Code coverage improved from `82% classes, with 64% lines covered` to `88% classes, 88% lines covered`
   
   ## Does this pull request potentially affect one of the following parts:
   * Dependencies (does it add or upgrade a dependency): no
   * The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   * The serializers: no
   * The runtime per-record code paths (performance sensitive): no
   * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   * The S3 file system connector: no
   
   ## Documentation
   * Does this pull request introduce a new feature? no
   * If yes, how is the feature documented? n/a
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-aws] dannycranmer merged pull request #24: [FLINK-29895][Connectors/DynamoDB] Migrate integration tests to unit tests and improve unit test coverage

Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #24:
URL: https://github.com/apache/flink-connector-aws/pull/24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #24: [FLINK-29895][Connectors/DynamoDB] Migrate integration tests to unit tests and improve unit test coverage

Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #24:
URL: https://github.com/apache/flink-connector-aws/pull/24#discussion_r1031699407


##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkTest.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.flink.connector.dynamodb.sink;

Review Comment:
   Missing copyright



##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkTest.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.flink.connector.dynamodb.sink;
+
+import org.apache.flink.connector.base.sink.writer.TestSinkInitContext;
+
+import org.junit.Test;

Review Comment:
   Please use Junit 5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #24: [FLINK-29895][Connectors/DynamoDB] Migrate integration tests to unit tests and improve unit test coverage

Posted by GitBox <gi...@apache.org>.
hlteoh37 commented on code in PR #24:
URL: https://github.com/apache/flink-connector-aws/pull/24#discussion_r1031701959


##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkTest.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.flink.connector.dynamodb.sink;

Review Comment:
   resolved



##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkTest.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.flink.connector.dynamodb.sink;
+
+import org.apache.flink.connector.base.sink.writer.TestSinkInitContext;
+
+import org.junit.Test;

Review Comment:
   done. good spot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org