[jira] [Comment Edited] (HBASE-21661) Provide Thrift2 implementation of Table/Admin

["Allan Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736637#comment-16736637 ] 

Allan Yang edited comment on HBASE-21661 at 1/8/19 2:16 AM:
------------------------------------------------------------

[~stack], thanks for reminding, I will add those comments to RN and description. As for the patch, can I have a +1? the javac warning is caused by generated thrift code. And I will fix the checkstyle warning on commit(and for those comments on the RB).
[~Apache9] mentioned before that can we generate thrift code in compile phase like proto, but after a careful investigation, I have found that, if we embed thrift generation to compile phase, that will require anyone who want to build HBase must have a thrift installed(unlike proto, proto maven compile plugin have taken care for that ). That was unacceptable, so , let's keep it this way for now.


was (Author: allan163):
[~stack], thanks for reminding, I will add those comments to RN and description. As for the patch, can I have a +1? the javac warning is caused by generated thrift code. And I will fix the checkstyle warning on commit(and for those comments on the RB).
[~Apache9] mentioned before that can we generate thrift code in compile phase like proto, but after a careful investigation, I have found that, if we embed thrift generation to compile phase, that will require anyone who what build HBase must have a thrift installed(unlike proto, proto maven compile plugin have taken care for that ). That was unacceptable, so , let's keep it this way for now.

> Provide Thrift2 implementation of Table/Admin
> ---------------------------------------------
>
>                 Key: HBASE-21661
>                 URL: https://issues.apache.org/jira/browse/HBASE-21661
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-21661.patch, HBASE-21661.v2.patch, HBASE-21661.v3.patch, HBASE-21661.v4.patch, HBASE-21661.v5.patch
>
>
> Provide Thrift2 implementation of Table/Admin, making Java user to use thrift client more easily(Some environment which can not expose ZK or RS Servers directly require thrift or REST protocol even using Java). 
> Another Example of this is RemoteHTable and RemoteAdmin, they are REST connectors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)