You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Erik Bengtson (JIRA)" <ji...@apache.org> on 2007/11/17 12:37:43 UTC
[jira] Created: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JDO-552
URL: https://issues.apache.org/jira/browse/JDO-552
Project: JDO
Issue Type: Improvement
Components: api2
Reporter: Erik Bengtson
Priority: Trivial
These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
JDOFatalDataStoreException
JDOObjectNotFoundException
JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603090#action_12603090 ]
Craig Russell commented on JDO-552:
-----------------------------------
We should probably add tck tests to verify that users can call the new constructors.
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Craig Russell
> Priority: Trivial
> Fix For: JDO 2 maintenance release 2
>
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Russell resolved JDO-552.
-------------------------------
Resolution: Fixed
clr% svn commit -m "JDO-552 Add constructors for consistency" ../api2
Sending api2/src/java/javax/jdo/JDODetachedFieldAccessException.java
Sending api2/src/java/javax/jdo/JDOFatalDataStoreException.java
Sending api2/src/java/javax/jdo/JDOFatalInternalException.java
Sending api2/src/java/javax/jdo/JDOObjectNotFoundException.java
Sending api2/src/java/javax/jdo/JDOOptimisticVerificationException.java
Sending api2/src/java/javax/jdo/JDOUserCallbackException.java
Transmitting file data ......
Committed revision 664161.
clr% svn commit -m "JDO-552 Add constructors for consistency" .
Sending tck2/src/conf/jdo-2_1-signatures.txt
Sending tck2/src/conf/runonce.conf
Adding tck2/src/java/org/apache/jdo/tck/api/exceptions
Adding tck2/src/java/org/apache/jdo/tck/api/exceptions/ExceptionConstructor.java
Transmitting file data ...
Committed revision 664162.
clr% svn commit -m "JDO-552 Add constructors for consistency" .
Sending api2-legacy/src/java/javax/jdo/JDODetachedFieldAccessException.java
Sending api2-legacy/src/java/javax/jdo/JDOFatalDataStoreException.java
Sending api2-legacy/src/java/javax/jdo/JDOFatalInternalException.java
Sending api2-legacy/src/java/javax/jdo/JDOObjectNotFoundException.java
Sending api2-legacy/src/java/javax/jdo/JDOOptimisticVerificationException.java
Sending api2-legacy/src/java/javax/jdo/JDOUserCallbackException.java
Transmitting file data ......
Committed revision 664171.
clr% svn commit -m "JDO-552 Add constructors for consistency" .
Sending tck2-legacy/src/conf/jdo-2_1-signatures.txt
Sending tck2-legacy/src/conf/runonce.conf
Adding tck2-legacy/src/java/org/apache/jdo/tck/api/exceptions
Adding tck2-legacy/src/java/org/apache/jdo/tck/api/exceptions/ExceptionConstructor.java
Transmitting file data ..
Committed revision 664174.
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Craig Russell
> Priority: Trivial
> Fix For: JDO 2 maintenance release 2
>
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543658 ]
Craig Russell commented on JDO-552:
-----------------------------------
I'll withdraw my objection, then. If you want to patch these three exceptions to be consistent with the rest, ok.
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Priority: Trivial
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543708 ]
Craig Russell commented on JDO-552:
-----------------------------------
Good. Just a couple of comments.
1. This would apply to both api2 and api2-legacy.
2. The tck signature test file jdo-2_1-signatures.txt also needs to be updated.
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Priority: Trivial
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Erik Bengtson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Bengtson updated JDO-552:
------------------------------
Attachment: JDO-552.patch
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Priority: Trivial
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543429 ]
Craig Russell commented on JDO-552:
-----------------------------------
This is by design. The rationale for having a failed object is that this is the object that was responsible for the exception, and the assumption is that once an object has an exception for the current operation, it is considered failed and no further action is taken.
The rationale for a Throwable[ ] is that many JDO operations act on multiple objects, and each object might have a different reason for failing. So the pattern is that each object is attempted and if it fails, the exception is added to the Throwable[ ].
Can you give an example where you would have a failed object that was not one of the failed objects in the Throwable[ ]?
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Priority: Trivial
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Erik Bengtson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543648 ]
Erik Bengtson commented on JDO-552:
-----------------------------------
All JDO exceptions, except the above, take an array of Throwable and a failed object. That's why I raised the issue
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Priority: Trivial
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Erik Bengtson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Bengtson reassigned JDO-552:
---------------------------------
Assignee: Erik Bengtson
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Priority: Trivial
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Russell reassigned JDO-552:
---------------------------------
Assignee: Craig Russell (was: Erik Bengtson)
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Craig Russell
> Priority: Trivial
> Fix For: JDO 2 maintenance release 2
>
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JDO-552) JDOFatalDataStoreException,
JDOObjectNotFoundException and JDOOptimisticVerificationException dont
allow nested exceptions and failed objects together
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Russell updated JDO-552:
------------------------------
Fix Version/s: JDO 2 maintenance release 2
> JDOFatalDataStoreException, JDOObjectNotFoundException and JDOOptimisticVerificationException dont allow nested exceptions and failed objects together
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-552
> URL: https://issues.apache.org/jira/browse/JDO-552
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Erik Bengtson
> Assignee: Craig Russell
> Priority: Trivial
> Fix For: JDO 2 maintenance release 2
>
> Attachments: JDO-552.patch
>
>
> These 3 exceptions have constructors (String msg, Throwable[] ex) and (String msg, Object failedObject), but dont have a (String msg, Throwable[], Object failedObject)
> JDOFatalDataStoreException
> JDOObjectNotFoundException
> JDOOptimisticVerificationException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.