You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/06/13 14:01:36 UTC
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13633
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
IMPALA-8585: Insert data into ACID table during dataload
Insert some data into insert_only_transactional_table during
dataload and add tests that read it. Unlike current ACID tests,
this new test is ran for every file format, not just text.
Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
---
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/acid-all-formats.test
M tests/query_test/test_acid.py
3 files changed, 38 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13633/1
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3770/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 17:57:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13633
to look at the new patch set (#2).
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
IMPALA-8585: Insert data into ACID table during dataload
Insert some data into insert_only_transactional_table during
dataload and add tests that read it. Unlike current ACID tests,
this new test is ran for every file format, not just text.
Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
---
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/acid-all-formats.test
M tests/query_test/test_acid.py
3 files changed, 39 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13633/2
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py@55
PS2, Line 55: class TestAcidAllFormats(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 17:19:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql@2137
PS1, Line 2137: -- Compactions could be also interesting, but seem to be sporadically very slow.
> can you file a JIRA for this issue that you mentioned?
mind filing this JIRA and adding a TODO here? then we can commit this with the workaround for now but also track the fix
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:25:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13633
to look at the new patch set (#3).
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
IMPALA-8585: Insert data into ACID table during dataload
Insert some data into insert_only_transactional_table during
dataload and add tests that read it. Unlike current ACID tests,
this new test is ran for every file format, not just text.
Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
---
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/acid-all-formats.test
M tests/query_test/test_acid.py
3 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13633/3
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3611/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:43:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3771/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 18:02:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 3:
(2 comments)
Please ignore patch set 2, it ignored some additional stuff by mistake.
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql@2137
PS1, Line 2137: -- Compactions could be also interesting, but seem to be sporadically very slow.
> mind filing this JIRA and adding a TODO here? then we can commit this with
Done
http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py@55
PS2, Line 55: # Tests that should run for all (HDFS based) table formats, not just text.
> flake8: E302 expected 2 blank lines, found 1
Done
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 17:24:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13633/1/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13633/1/tests/query_test/test_acid.py@55
PS1, Line 55: class TestAcidAllFormats(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:02:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:
http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql@2137
PS1, Line 2137: -- Compactions could be also interesting, but seem to be sporadically very slow.
can you file a JIRA for this issue that you mentioned?
--
To view, visit http://gerrit.cloudera.org:8080/13633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9
Gerrit-Change-Number: 13633
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 13 Jun 2019 19:52:04 +0000
Gerrit-HasComments: Yes