You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/27 06:10:44 UTC

[GitHub] [flink] gaoyajun02 opened a new pull request #17008: [FLINK-24013] Add IssueNavigationLink

gaoyajun02 opened a new pull request #17008:
URL: https://github.com/apache/flink/pull/17008


   
   ## What is the purpose of the change
   
   Add IssueNavigationLink to make IDEA support hyperlink on JIRA Ticket and GitHub PR on Git plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] gaoyajun02 commented on a change in pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on a change in pull request #17008:
URL: https://github.com/apache/flink/pull/17008#discussion_r697180873



##########
File path: .gitignore
##########
@@ -1,7 +1,9 @@
 .cache
 scalastyle-output.xml
 .classpath
-.idea
+.idea/
+# FLINK-24013: Add IssueNavigationLink to make IDEA support hyperlink on JIRA Ticket and GitHub PR on Git plugin.

Review comment:
       Ok, removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17008:
URL: https://github.com/apache/flink/pull/17008#issuecomment-906975239


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dd49a0410466052338e5e41d49d87f15d816ba9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung commented on a change in pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #17008:
URL: https://github.com/apache/flink/pull/17008#discussion_r697178367



##########
File path: .gitignore
##########
@@ -1,7 +1,9 @@
 .cache
 scalastyle-output.xml
 .classpath
-.idea
+.idea/
+# FLINK-24013: Add IssueNavigationLink to make IDEA support hyperlink on JIRA Ticket and GitHub PR on Git plugin.

Review comment:
       No need to do this, git history will tell us

##########
File path: .idea/vcs.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+-->
+<project version="4">
+  <component name="IssueNavigationConfiguration">
+    <option name="links">
+      <list>
+        <IssueNavigationLink>
+		  <option name="issueRegexp" value="[A-Z]+\-\d+" />

Review comment:
       alingn the indent please




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17008:
URL: https://github.com/apache/flink/pull/17008#issuecomment-906953123


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 086577cb6374a79e3cdcefd9cacecfcd3165b3ef (Fri Aug 27 06:13:19 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24013).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] gaoyajun02 commented on a change in pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on a change in pull request #17008:
URL: https://github.com/apache/flink/pull/17008#discussion_r697181787



##########
File path: .idea/vcs.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+-->
+<project version="4">
+  <component name="IssueNavigationConfiguration">
+    <option name="links">
+      <list>
+        <IssueNavigationLink>
+		  <option name="issueRegexp" value="[A-Z]+\-\d+" />

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17008:
URL: https://github.com/apache/flink/pull/17008#issuecomment-906975239


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61f056aa2f51d37a62be20ed436973bd8998acb1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "61f056aa2f51d37a62be20ed436973bd8998acb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dd49a0410466052338e5e41d49d87f15d816ba9 UNKNOWN
   * 61f056aa2f51d37a62be20ed436973bd8998acb1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung closed pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #17008:
URL: https://github.com/apache/flink/pull/17008


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17008: [FLINK-24013] Add IssueNavigationLink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17008:
URL: https://github.com/apache/flink/pull/17008#issuecomment-906975239


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0dd49a0410466052338e5e41d49d87f15d816ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61f056aa2f51d37a62be20ed436973bd8998acb1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22933",
       "triggerID" : "61f056aa2f51d37a62be20ed436973bd8998acb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dd49a0410466052338e5e41d49d87f15d816ba9 UNKNOWN
   * 61f056aa2f51d37a62be20ed436973bd8998acb1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22933) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org