You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/20 22:47:14 UTC

[GitHub] ajacques commented on issue #20974: [SPARK-23862][SQL] Spark ExpressionEncoder should support java enum type in scala

ajacques commented on issue #20974: [SPARK-23862][SQL] Spark ExpressionEncoder should support java enum type in scala
URL: https://github.com/apache/spark/pull/20974#issuecomment-449160434
 
 
   If I understand this PR correctly, this is going to be internally using the String representation of the Enum instead of some type of ordinal. I like the support for Enums, but I've seen cases where using a string instead of the ordinal significantly increases the data set size. Is there a reason why we're preferring String over an ordinal?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org