You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/20 02:23:28 UTC

[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request, #10501: [Fix] [Worker] Fix worker will hang if fails to start

ruanwenjun opened a new pull request, #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501

   ## Purpose of the pull request
   
   cherry-pick #10342
   
   ## Brief change log
   
   Change thread to daemon
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1162535521

   I rerun the fail UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng merged pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1162546273

   > The CI failed, since the version of 3.0.0-beta is not dev.
   > 
   > <img alt="image" width="1674" src="https://user-images.githubusercontent.com/22415594/174928135-61c1fb98-cb65-4db2-a63d-1df7589d92f5.png">
   
   
   Got it. I will merge this pr. 
   But is there any solution to this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1159946080

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10501?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`3.0.0-beta-2-prepare@ac5179b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   ```diff
   @@                   Coverage Diff                   @@
   ##             3.0.0-beta-2-prepare   #10501   +/-   ##
   =======================================================
     Coverage                        ?   40.70%           
     Complexity                      ?     4594           
   =======================================================
     Files                           ?      834           
     Lines                           ?    33917           
     Branches                        ?     3768           
   =======================================================
     Hits                            ?    13806           
     Misses                          ?    18779           
     Partials                        ?     1332           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10501?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10501?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac5179b...8b3b1fe](https://codecov.io/gh/apache/dolphinscheduler/pull/10501?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1160584369

   @caishunfeng @SnowMoon-Dev Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1159950669

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10501)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=CODE_SMELL) [128 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10501&resolved=false&types=CODE_SMELL)
   
   [![30.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '30.5%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10501&metric=new_coverage&view=list) [30.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10501&metric=new_coverage&view=list)  
   [![0.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.4%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10501&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10501&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10501: [Fix] [Worker] Fix worker will hang if fails to start

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10501:
URL: https://github.com/apache/dolphinscheduler/pull/10501#issuecomment-1162543518

   The CI failed, since the version of 3.0.0-beta is not dev.
   
   <img width="1674" alt="image" src="https://user-images.githubusercontent.com/22415594/174928135-61c1fb98-cb65-4db2-a63d-1df7589d92f5.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org