You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/21 08:56:43 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #533: interpreters/wamr: Support latest snapshot for main branch
no1wudi opened a new pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533
## Summary
Now supports specifying the version number of wamr as main.
## Impact
None
## Testing
Tested on stm32f429i-disco
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546604227
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
Review comment:
Done, I'll send another patch to do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594382
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
$(WAMR_UNPACK): $(WAMR_TARBALL)
$(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)"
- $(Q) tar xzvf $(WAMR_TARBALL)
- $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK)
+ $(Q) unzip $(WAMR_TARBALL)
+ $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION) $(WAMR_UNPACK)
context:: $(WAMR_UNPACK)
+clean::
+ $(call DELDIR, $(WAMR_UNPACK))
+
Review comment:
**WAMR_UNPACK** is the directory of unpacked context, but source tarball still here.
If WAMR_VERSION changed in menuconfig, the correct source can be unpacked after `make clean`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546601969
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
Review comment:
But other location use wget too. it's better to make a new patch to replace all wget to curl if the change can simplify the prerequest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546596492
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
Review comment:
No functional difference, just because curl does not need to be installed on some systems (like Mac)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594247
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
$(WAMR_UNPACK): $(WAMR_TARBALL)
$(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)"
- $(Q) tar xzvf $(WAMR_TARBALL)
- $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK)
+ $(Q) unzip $(WAMR_TARBALL)
+ $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION) $(WAMR_UNPACK)
context:: $(WAMR_UNPACK)
+clean::
+ $(call DELDIR, $(WAMR_UNPACK))
+
Review comment:
Yes, clean should be removed.
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
Review comment:
why switch to curl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546590051
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
$(WAMR_UNPACK): $(WAMR_TARBALL)
$(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)"
- $(Q) tar xzvf $(WAMR_TARBALL)
- $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK)
+ $(Q) unzip $(WAMR_TARBALL)
+ $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION) $(WAMR_UNPACK)
context:: $(WAMR_UNPACK)
+clean::
+ $(call DELDIR, $(WAMR_UNPACK))
+
Review comment:
What's made during `context` should be removed during `clean_context` or `distclean`.
If we remove it during `clean` we would always have to re-download it if we want a clean build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #533:
URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546598242
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
$(WAMR_UNPACK): $(WAMR_TARBALL)
$(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)"
- $(Q) tar xzvf $(WAMR_TARBALL)
- $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK)
+ $(Q) unzip $(WAMR_TARBALL)
+ $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION) $(WAMR_UNPACK)
context:: $(WAMR_UNPACK)
+clean::
+ $(call DELDIR, $(WAMR_UNPACK))
+
Review comment:
OK, that requires `make distclean` after Kconfig option changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org