You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/08/02 18:32:50 UTC
Re: Review Request 35797: Updated Frameworkinfo.capabilities on
framework re-registration to support adding capabilities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
-----------------------------------------------------------
(Updated Aug. 2, 2015, 4:32 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2880
https://issues.apache.org/jira/browse/MESOS-2880
Repository: mesos
Description (updated)
-------
This updates both the master as well as the allocator. Added test for both.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc
src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
Diff: https://reviews.apache.org/r/35797/diff/
Testing
-------
make check
Thanks,
Aditi Dixit
Re: Review Request 35797: Updated Frameworkinfo.capabilities on
framework re-registration to support adding capabilities
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review93863
-----------------------------------------------------------
Bad patch!
Reviews applied: [35797]
Failed command: ./support/apply-review.sh -n -r 35797
Error:
2015-08-02 17:48:08 URL:https://reviews.apache.org/r/35797/diff/raw/ [11086/11086] -> "35797.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:486
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
error: patch failed: src/master/master.hpp:530
error: src/master/master.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 2, 2015, 4:32 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2015, 4:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates both the master as well as the allocator. Added test for both.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
> src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/35797/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 35797: Updated Frameworkinfo.capabilities on
framework re-registration to support adding capabilities
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review94102
-----------------------------------------------------------
Looks like you realized that you need to create a new review :) So I'll re-close this one.
- Vinod Kone
On Aug. 2, 2015, 4:32 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2015, 4:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates both the master as well as the allocator. Added test for both.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 3264d145d52b48852878abf7ab9be29ab98208cc
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
> src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/35797/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>