You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/17 05:09:41 UTC
[PR] Remove DaemonNamedLockFactoryAdapterFactoryImpl [maven-mvnd]
gnodet opened a new pull request, #1556:
URL: https://github.com/apache/maven-mvnd/pull/1556
## Summary
- Remove `DaemonNamedLockFactoryAdapterFactoryImpl` which overrode Maven Resolver's default named lock factory (`file-lock`) and name mapper (`file-gav`). Since resolver 2.0.0, these are already the defaults, making this class a no-op.
- Eliminates the dependency on resolver internal classes (`org.eclipse.aether.internal.impl.synccontext.named.*`), which broke when the constructor signature changed in resolver 2.0.14 (new `LockingInhibitorFactory` parameter).
- Unblocks the resolver version bump in #1538.
## Context
The class was introduced in [MNG-7586](https://github.com/apache/maven-mvnd/commit/7d25f0ad) when mvnd used resolver 1.9.2, which defaulted to `rwlock-local` + `gav`. The override to `file-lock` + `file-gav` was necessary then but became redundant when resolver 2.0.0 adopted the same defaults.
## Test plan
- [x] Full build passes (`mvnw verify -DskipTests`)
- No behavioral change — the resolver already uses `file-lock` + `file-gav` by default
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove DaemonNamedLockFactoryAdapterFactoryImpl [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1556:
URL: https://github.com/apache/maven-mvnd/pull/1556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove DaemonNamedLockFactoryAdapterFactoryImpl [maven-mvnd]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #1556:
URL: https://github.com/apache/maven-mvnd/pull/1556#issuecomment-4638738011
master CI has been red for 12 days — since the resolver 2.0.13 → 2.0.18 bump (#1613) landed on 2026-05-25 — and this already-approved, mergeable PR is the fix.
- master HEAD `c3e00b87`: [Early Access run](https://github.com/apache/maven-mvnd/actions/runs/26414776206) — `failure`, exactly the `DaemonNamedLockFactoryAdapterFactoryImpl:48` constructor mismatch this PR removes.
- Every PR opened against master since then inherits the break — e.g. [this 2026-06-03 dependabot run](https://github.com/apache/maven-mvnd/actions/runs/26920186961) burns on the same line.
- Verified locally: applying this PR's deletion onto current master HEAD `c3e00b87` and `gh pr checkout 1556` both build green (`BUILD SUCCESS`, 43 tests including integration tests, isolated `-Dmaven.repo.local`).
Anything blocking the merge that someone from outside could help unblock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove DaemonNamedLockFactoryAdapterFactoryImpl [maven-mvnd]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1556:
URL: https://github.com/apache/maven-mvnd/pull/1556#issuecomment-4640389384
@cstamas Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org