You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michalxo <gi...@git.apache.org> on 2017/06/21 07:22:13 UTC
[GitHub] activemq-artemis pull request #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp ...
GitHub user michalxo opened a pull request:
https://github.com/apache/activemq-artemis/pull/1355
ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp interceptor properties tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalxo/activemq-artemis entmqbr-559-qe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1355
----
commit 8acf97c584d9dee2af317d1a213f0442787263ed
Author: Michal Tóth <mt...@redhat.com>
Date: 2017-06-21T07:06:46Z
ADD(Tests) AMQP,MQTT,Stomp interceptor properties tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp interce...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1355
Can the commit have an apache jira, and commit with link to the apache jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1355: ARTEMIS-607 New tests AMQP,MQTT,Stomp i...
Posted by michalxo <gi...@git.apache.org>.
Github user michalxo closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1355#discussion_r123174387
--- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveInterceptorTest.java ---
@@ -26,8 +26,12 @@
import org.apache.activemq.transport.amqp.client.AmqpReceiver;
import org.apache.activemq.transport.amqp.client.AmqpSender;
import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.apache.felix.resolver.util.ArrayMap;
--- End diff --
Can we use an alternative std java map such as hash map, tree map. rather than introducing a new code dependency. (felix is used for the maven bundlers but not currently as a code dep. doing a search of the code base)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1355: ARTEMIS-607 New tests AMQP,MQTT,Stomp i...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1355#discussion_r123182665
--- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveInterceptorTest.java ---
@@ -26,8 +26,12 @@
import org.apache.activemq.transport.amqp.client.AmqpReceiver;
import org.apache.activemq.transport.amqp.client.AmqpSender;
import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.apache.felix.resolver.util.ArrayMap;
--- End diff --
31 commits ;) wowsies you work fast :P
I think you may have accidentally brought in a lot of other commits in from your local repo, when doing your update :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp ...
Posted by michalxo <gi...@git.apache.org>.
Github user michalxo commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1355#discussion_r123177981
--- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveInterceptorTest.java ---
@@ -26,8 +26,12 @@
import org.apache.activemq.transport.amqp.client.AmqpReceiver;
import org.apache.activemq.transport.amqp.client.AmqpSender;
import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.apache.felix.resolver.util.ArrayMap;
--- End diff --
I was also surprised about IDEA offering only felix ArrayMap.
I would prefer using std lib as well. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1355: ARTEMIS-607 New tests AMQP,MQTT,Stomp intercep...
Posted by michalxo <gi...@git.apache.org>.
Github user michalxo commented on the issue:
https://github.com/apache/activemq-artemis/pull/1355
Yeah, I will close this PR and create a new one with corrected things.
First real PR did not worked out well. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---