You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Geir Magnusson Jr." <ge...@optonline.net> on 2002/01/07 11:15:21 UTC
[VOTE] Gabriel Sidler as committer for velocity-tools
I propose that we give Gabriel Sidler commit access to the
jakarta-velocity-tools CVS.
He was responsible for the struts interfacing code in the /struts part,
offered a few prototypes for the servlet and tool management, and as a
Struts user, would be a good person to enslave to, <ahem> er, get to work
on, the Struts part (and anything else in -tools ) as long as he keeps his
funny line endings to himself.
:)
Gabriel is about to offer a set of patches for velocity-tools, and that
should be used as an example (independent of my meddling) of what he will
bring for those that haven't seen his contributions.
Wait for his patches, but I will start off with a +1.
geir
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
"We will be judged not by the monuments we build, but by the monuments we
destroy" - Ada Louise Huxtable
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Patch for jakarta-velocity-tools (line termination problem)
Posted by Gabriel Sidler <si...@teamup.ch>.
"Geir Magnusson Jr." wrote:
>
> On 1/8/02 2:18 PM, "Gabriel Sidler" <si...@teamup.ch> wrote:
>
> > Attached is a patch that fixes the much discussed line
> > termination problems in jakarta-velocity-tools. Fairly
> > many files are impacted.
> >
> > Addiditonally I have made sure that all source files
> > now conform to the Velocity coding conventions.
> >
> > That's all for a first shot. Please let me know if you
> > see any issues with this patch. Otherwise, I will commit
> > it tommorow morning MET (about midnight EST :-) )
> >
> > Gabe
> >
> >
> >
>
> One note - I did some updates this morning, trying to work the build system
> into something a little different, so your build.xml patches (/struts and
> /tools level, if they were in there ) might be out of synch.
Yes, I did take those changes into consideration. About 2/3 of files were
affected.
The problem was likely that I send you with my prototype Windows-style
files and you imported those on a Unix(-like) plattform that didn't take
care of the necessary line terminator conversion. Now all should be fine.
Gabe
--
Gabriel Sidler
Software Engineer, Eivycom GmbH, Zurich, Switzerland
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Patch for jakarta-velocity-tools (line termination problem)
Posted by "Geir Magnusson Jr." <ge...@optonline.net>.
On 1/8/02 2:18 PM, "Gabriel Sidler" <si...@teamup.ch> wrote:
> Attached is a patch that fixes the much discussed line
> termination problems in jakarta-velocity-tools. Fairly
> many files are impacted.
>
> Addiditonally I have made sure that all source files
> now conform to the Velocity coding conventions.
>
> That's all for a first shot. Please let me know if you
> see any issues with this patch. Otherwise, I will commit
> it tommorow morning MET (about midnight EST :-) )
>
> Gabe
>
>
>
One note - I did some updates this morning, trying to work the build system
into something a little different, so your build.xml patches (/struts and
/tools level, if they were in there ) might be out of synch.
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
"Now what do we do?"
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Patch for jakarta-velocity-tools (line termination problem)
Posted by "Geir Magnusson Jr." <ge...@optonline.net>.
On 1/8/02 2:18 PM, "Gabriel Sidler" <si...@teamup.ch> wrote:
> Attached is a patch that fixes the much discussed line
> termination problems in jakarta-velocity-tools. Fairly
> many files are impacted.
>
> Addiditonally I have made sure that all source files
> now conform to the Velocity coding conventions.
>
> That's all for a first shot. Please let me know if you
> see any issues with this patch. Otherwise, I will commit
> it tommorow morning MET (about midnight EST :-) )
>
I started looking at this patch. Huge! :)
What was the problem? Did you figure it out?
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
"They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety." - Benjamin Franklin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Patch for jakarta-velocity-tools (line termination problem)
Posted by Gabriel Sidler <si...@teamup.ch>.
Attached is a patch that fixes the much discussed line
termination problems in jakarta-velocity-tools. Fairly
many files are impacted.
Addiditonally I have made sure that all source files
now conform to the Velocity coding conventions.
That's all for a first shot. Please let me know if you
see any issues with this patch. Otherwise, I will commit
it tommorow morning MET (about midnight EST :-) )
Gabe
--
Gabriel Sidler
Software Engineer, Eivycom GmbH, Zurich, Switzerland
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Ted Husted <hu...@apache.org>.
+1
(Non-binding, but as another Jakarta committer, I agree that Gabriel has
the Right Stuff.)
"Geir Magnusson Jr." wrote:
>
> I propose that we give Gabriel Sidler commit access to the
> jakarta-velocity-tools CVS.
>
> He was responsible for the struts interfacing code in the /struts part,
> offered a few prototypes for the servlet and tool management, and as a
> Struts user, would be a good person to enslave to, <ahem> er, get to work
> on, the Struts part (and anything else in -tools ) as long as he keeps his
> funny line endings to himself.
>
> :)
>
> Gabriel is about to offer a set of patches for velocity-tools, and that
> should be used as an example (independent of my meddling) of what he will
> bring for those that haven't seen his contributions.
>
> Wait for his patches, but I will start off with a +1.
>
> geir
>
> --
> Geir Magnusson Jr. geirm@optonline.net
> System and Software Consulting
> "We will be judged not by the monuments we build, but by the monuments we
> destroy" - Ada Louise Huxtable
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Building Java web applications with Struts.
-- Tel +1 585 737-3463.
-- Web http://www.husted.com/struts/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Geir Magnusson Jr." <ge...@optonline.net> writes:
> I propose that we give Gabriel Sidler commit access to the
> jakarta-velocity-tools CVS.
>
> He was responsible for the struts interfacing code in the /struts part,
> offered a few prototypes for the servlet and tool management, and as a
> Struts user, would be a good person to enslave to, <ahem> er, get to work
> on, the Struts part (and anything else in -tools ) as long as he keeps his
> funny line endings to himself.
+1. Happy to have you, Gabe.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by "Geir Magnusson Jr." <ge...@optonline.net>.
On 1/7/02 7:46 AM, "Christoph Reck" <Ch...@dlr.de> wrote:
> +1 grom me, for whatever it's worth.
>
> Geir, some of the velocity-tools maybe could be made part of the
> commons.utils package, thus avoiding similar conflicts as the
> Validator/Intake discussion. That package already has many *good*
> tools that can be used from within velocity.
Good feedback.
One of the things I want to do is have a top-level tools documentation that
points to other places, like commons utils.
>
> Only the string velocity dependent tools should remain in velocity
> land.
>
> "Geir Magnusson Jr." wrote:
>>
>> I propose that we give Gabriel Sidler commit access to the
>> jakarta-velocity-tools CVS.
>>
>> He was responsible for the struts interfacing code in the /struts part,
>> offered a few prototypes for the servlet and tool management, and as a
>> Struts user, would be a good person to enslave to, <ahem> er, get to work
>> on, the Struts part (and anything else in -tools ) as long as he keeps his
>> funny line endings to himself.
>>
>> :)
>>
>> Gabriel is about to offer a set of patches for velocity-tools, and that
>> should be used as an example (independent of my meddling) of what he will
>> bring for those that haven't seen his contributions.
>>
>> Wait for his patches, but I will start off with a +1.
>>
>> geir
>>
>> --
>> Geir Magnusson Jr. geirm@optonline.net
>> System and Software Consulting
>> "We will be judged not by the monuments we build, but by the monuments we
>> destroy" - Ada Louise Huxtable
>>
>> --
>> To unsubscribe, e-mail:
>> <ma...@jakarta.apache.org>
>> For additional commands, e-mail:
>> <ma...@jakarta.apache.org>
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
"We will be judged not by the monuments we build, but by the monuments we
destroy" - Ada Louise Huxtable
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Christoph Reck <Ch...@dlr.de>.
+1 grom me, for whatever it's worth.
Geir, some of the velocity-tools maybe could be made part of the
commons.utils package, thus avoiding similar conflicts as the
Validator/Intake discussion. That package already has many *good*
tools that can be used from within velocity.
Only the string velocity dependent tools should remain in velocity
land.
"Geir Magnusson Jr." wrote:
>
> I propose that we give Gabriel Sidler commit access to the
> jakarta-velocity-tools CVS.
>
> He was responsible for the struts interfacing code in the /struts part,
> offered a few prototypes for the servlet and tool management, and as a
> Struts user, would be a good person to enslave to, <ahem> er, get to work
> on, the Struts part (and anything else in -tools ) as long as he keeps his
> funny line endings to himself.
>
> :)
>
> Gabriel is about to offer a set of patches for velocity-tools, and that
> should be used as an example (independent of my meddling) of what he will
> bring for those that haven't seen his contributions.
>
> Wait for his patches, but I will start off with a +1.
>
> geir
>
> --
> Geir Magnusson Jr. geirm@optonline.net
> System and Software Consulting
> "We will be judged not by the monuments we build, but by the monuments we
> destroy" - Ada Louise Huxtable
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
:) Christoph Reck
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by "Geir Magnusson Jr." <ge...@optonline.net>.
On 1/7/02 2:54 PM, "Jon Scott Stevens" <jo...@latchkey.com> wrote:
> on 1/7/02 9:34 AM, "Gabriel Sidler" <si...@teamup.ch> wrote:
>
>> Right, sorry for that. I didn't expect this prototype to end up
>> in a cvs repository that quickly. I reused code from several other
>> projects. That's why the coding style is a little patchy. I will
>> clean all this up in a next version.
>
> Great thanks! +1. Welcome!
>
That's three then.
:)
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
You're going to end up getting pissed at your software
anyway, so you might as well not pay for it. Try Open Source.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Jon Scott Stevens <jo...@latchkey.com>.
on 1/7/02 9:34 AM, "Gabriel Sidler" <si...@teamup.ch> wrote:
> Right, sorry for that. I didn't expect this prototype to end up
> in a cvs repository that quickly. I reused code from several other
> projects. That's why the coding style is a little patchy. I will
> clean all this up in a next version.
Great thanks! +1. Welcome!
-jon
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Gabriel Sidler <si...@teamup.ch>.
Jon Scott Stevens wrote:
>
> on 1/7/02 2:15 AM, "Geir Magnusson Jr." <ge...@optonline.net> wrote:
>
> > I propose that we give Gabriel Sidler commit access to the
> > jakarta-velocity-tools CVS.
> >
> > He was responsible for the struts interfacing code in the /struts part,
> > offered a few prototypes for the servlet and tool management, and as a
> > Struts user, would be a good person to enslave to, <ahem> er, get to work
> > on, the Struts part (and anything else in -tools ) as long as he keeps his
> > funny line endings to himself.
> >
> > :)
> >
> > Gabriel is about to offer a set of patches for velocity-tools, and that
> > should be used as an example (independent of my meddling) of what he will
> > bring for those that haven't seen his contributions.
> >
> > Wait for his patches, but I will start off with a +1.
> >
> > geir
>
> I'm conditional on a +1. My condition is as long as he agrees to format all
> checked in code according to:
>
> http://jakarta.apache.org/velocity/code-standards.html
Sure. No problem.
What are your bugs conventions? :-)
>
> So far, that hasn't been the case.
>
Right, sorry for that. I didn't expect this prototype to end up
in a cvs repository that quickly. I reused code from several other
projects. That's why the coding style is a little patchy. I will
clean all this up in a next version.
>
> -jon
Gabe
--
Gabriel Sidler
Software Engineer, Eivycom GmbH, Zurich, Switzerland
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by "Geir Magnusson Jr." <ge...@optonline.net>.
On 1/7/02 11:29 AM, "Jon Scott Stevens" <jo...@latchkey.com> wrote:
> on 1/7/02 2:15 AM, "Geir Magnusson Jr." <ge...@optonline.net> wrote:
>
>> I propose that we give Gabriel Sidler commit access to the
>> jakarta-velocity-tools CVS.
>>
>> He was responsible for the struts interfacing code in the /struts part,
>> offered a few prototypes for the servlet and tool management, and as a
>> Struts user, would be a good person to enslave to, <ahem> er, get to work
>> on, the Struts part (and anything else in -tools ) as long as he keeps his
>> funny line endings to himself.
>>
>> :)
>>
>> Gabriel is about to offer a set of patches for velocity-tools, and that
>> should be used as an example (independent of my meddling) of what he will
>> bring for those that haven't seen his contributions.
>>
>> Wait for his patches, but I will start off with a +1.
>>
>> geir
>
> I'm conditional on a +1. My condition is as long as he agrees to format all
> checked in code according to:
>
> http://jakarta.apache.org/velocity/code-standards.html
>
> So far, that hasn't been the case.
That's why the "about to offer a set of patches" (and I mentioned the
formatting in a private note)
Anything checked in to -tools so far that has problems is my fault - I
thought I went over all the code (except for struts/example war)...
>
> -jon
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
Geir Magnusson Jr. geirm@optonline.net
System and Software Consulting
"We will be judged not by the monuments we build, but by the monuments we
destroy" - Ada Louise Huxtable
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Gabriel Sidler as committer for velocity-tools
Posted by Jon Scott Stevens <jo...@latchkey.com>.
on 1/7/02 2:15 AM, "Geir Magnusson Jr." <ge...@optonline.net> wrote:
> I propose that we give Gabriel Sidler commit access to the
> jakarta-velocity-tools CVS.
>
> He was responsible for the struts interfacing code in the /struts part,
> offered a few prototypes for the servlet and tool management, and as a
> Struts user, would be a good person to enslave to, <ahem> er, get to work
> on, the Struts part (and anything else in -tools ) as long as he keeps his
> funny line endings to himself.
>
> :)
>
> Gabriel is about to offer a set of patches for velocity-tools, and that
> should be used as an example (independent of my meddling) of what he will
> bring for those that haven't seen his contributions.
>
> Wait for his patches, but I will start off with a +1.
>
> geir
I'm conditional on a +1. My condition is as long as he agrees to format all
checked in code according to:
http://jakarta.apache.org/velocity/code-standards.html
So far, that hasn't been the case.
-jon
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>