You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/11 09:18:28 UTC

[GitHub] [incubator-zipkin] adriancole edited a comment on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf

adriancole edited a comment on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf
URL: https://github.com/apache/incubator-zipkin/pull/2584#issuecomment-491494718
 
 
   note: this puts us within "spitting distance" of google's proto library, yet with no external dependencies
   
   ```
   ProtoCodecBenchmarks.bytes_protobufDecoder:bytes_protobufDecoder·p0.99       sample            1974.108                us/op
   ProtoCodecBenchmarks.bytes_protobufDecoder:·gc.alloc.rate.norm               sample     15  2023204.399 ±     33.559    B/op
   ProtoCodecBenchmarks.bytes_wireDecoder:bytes_wireDecoder·p0.99               sample            2368.840                us/op
   ProtoCodecBenchmarks.bytes_wireDecoder:·gc.alloc.rate.norm                   sample     15  2435408.756 ±     54.127    B/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99           sample            2162.688                us/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm                 sample     15  2095172.026 ±     45.379    B/op
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services