You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2017/09/13 11:58:17 UTC
[myfaces-tobago] branch master updated: TOBAGO-1798: First click on
Tab doesn't work after set rendered from false to true
This is an automated email from the ASF dual-hosted git repository.
lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
The following commit(s) were added to refs/heads/master by this push:
new b03af6d TOBAGO-1798: First click on Tab doesn't work after set rendered from false to true
b03af6d is described below
commit b03af6d27fd0fde29f3eb265bc9324b4d969647e
Author: Udo Schnurpfeil <lo...@apache.org>
AuthorDate: Wed Sep 13 13:51:12 2017 +0200
TOBAGO-1798: First click on Tab doesn't work after set rendered from false to true
---
.../renderkit/renderer/TabGroupRenderer.java | 54 +++++++++++-----------
1 file changed, 26 insertions(+), 28 deletions(-)
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
index d8e1de2..b643d5a 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
@@ -80,34 +80,32 @@ public class TabGroupRenderer extends RendererBase implements ComponentSystemEve
for (final UIComponent child : tabGroup.getChildren()) {
if (child instanceof UITab) {
final UITab tab = (UITab) child;
- if (tab.isRendered()) {
- final FacesContext facesContext = FacesContext.getCurrentInstance();
- final ClientBehaviors click = ClientBehaviors.click;
- switch (tabGroup.getSwitchType()) {
- case none:
- break;
- case client:
- // todo: implement a client behavior which can call local scripts (respect CSP)
- break;
- case reloadTab:
- final AjaxBehavior ajaxBehavior = new AjaxBehavior();
- final Collection<String> ids = Collections.singleton(
- UINamingContainer.getSeparatorChar(facesContext) + tabGroup.getClientId(facesContext));
- ajaxBehavior.setExecute(ids);
- ajaxBehavior.setRender(ids);
- tab.addClientBehavior(click.name(), ajaxBehavior);
- break;
- case reloadPage:
- final EventBehavior eventBehavior = new EventBehavior();
- tab.addClientBehavior(click.name(), eventBehavior);
- final UIEvent component = (UIEvent) ComponentUtils.createComponent(
- facesContext, UIEvent.COMPONENT_TYPE, RendererTypes.Event, "_click");
- component.setEvent(click);
- tab.getChildren().add(component);
- break;
- default:
- LOG.error("Unknown switch type: '{}'", tabGroup.getSwitchType());
- }
+ final FacesContext facesContext = FacesContext.getCurrentInstance();
+ final ClientBehaviors click = ClientBehaviors.click;
+ switch (tabGroup.getSwitchType()) {
+ case none:
+ break;
+ case client:
+ // todo: implement a client behavior which can call local scripts (respect CSP)
+ break;
+ case reloadTab:
+ final AjaxBehavior ajaxBehavior = new AjaxBehavior();
+ final Collection<String> ids = Collections.singleton(
+ UINamingContainer.getSeparatorChar(facesContext) + tabGroup.getClientId(facesContext));
+ ajaxBehavior.setExecute(ids);
+ ajaxBehavior.setRender(ids);
+ tab.addClientBehavior(click.name(), ajaxBehavior);
+ break;
+ case reloadPage:
+ final EventBehavior eventBehavior = new EventBehavior();
+ tab.addClientBehavior(click.name(), eventBehavior);
+ final UIEvent component = (UIEvent) ComponentUtils.createComponent(
+ facesContext, UIEvent.COMPONENT_TYPE, RendererTypes.Event, "_click");
+ component.setEvent(click);
+ tab.getChildren().add(component);
+ break;
+ default:
+ LOG.error("Unknown switch type: '{}'", tabGroup.getSwitchType());
}
}
}
--
To stop receiving notification emails like this one, please contact
['"commits@myfaces.apache.org" <co...@myfaces.apache.org>'].