[GitHub] [incubator-superset] khtruong opened a new pull request #7200: Add default tooltips to deck.gl viz types

[GitBox <gi...@apache.org>]

khtruong opened a new pull request #7200: Add default tooltips to deck.gl viz types
URL: https://github.com/apache/incubator-superset/pull/7200
 
 
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
     http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   ##### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Add default tooltips to deck.gl viz types. If the user specifies his or her own custom tooltips, we use those tooltips instead. Note that in geojson and path vizs, the user must specify the extra props. This isn't really that discoverable so we should perhaps think of improving that experience.
   
   ##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Arc Viz
   <img width="528" alt="Screen Shot 2019-04-01 at 9 41 56 PM" src="https://user-images.githubusercontent.com/47833996/55377427-c31b0b80-54c9-11e9-8e8b-410197c46715.png">
   
   Grid Viz
   <img width="503" alt="Screen Shot 2019-04-01 at 9 43 57 PM" src="https://user-images.githubusercontent.com/47833996/55377497-0d03f180-54ca-11e9-89a5-71d636b28363.png">
   
   Hex Viz
   <img width="502" alt="Screen Shot 2019-04-01 at 9 44 42 PM" src="https://user-images.githubusercontent.com/47833996/55377507-12f9d280-54ca-11e9-99f1-f66fe54cc4ac.png">
   
   Scatter Plot
   <img width="478" alt="Screen Shot 2019-04-01 at 9 45 56 PM" src="https://user-images.githubusercontent.com/47833996/55377515-19884a00-54ca-11e9-9974-f1c15949c85e.png">
   
   
   ##### TEST PLAN
   <!--- What steps were taken to verify -->
   Manual testing
   
   ##### ADDITIONAL INFORMATION
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> 
   <!--- Check any relevant boxes with "x" -->
       [ ] Has associated issue:
       [ ] Changes UI
       [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
       [x ] Introduces new feature or API
       [ ] Removes existing feature or API
       [ ] Fixes bug
       [ ] Refactors code
       [ ] Adds test(s)
   
   ##### REVIEWERS
   @xtinec @betodealmeida @kristw @williaster 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org