You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2014/08/09 23:20:50 UTC
svn commit: r1617018 - in /httpd/httpd/trunk: CHANGES
modules/filters/mod_ratelimit.c
Author: covener
Date: Sat Aug 9 21:20:50 2014
New Revision: 1617018
URL: http://svn.apache.org/r1617018
Log:
PR56832 -- mod_ratelimit reports at ERROR level evertyime a lower-level filter
encounters an error. Since the core output filter only emits TRACE1, a higher
level filter shouldn't log the same condition as ERROR.
Modified:
httpd/httpd/trunk/CHANGES
httpd/httpd/trunk/modules/filters/mod_ratelimit.c
Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1617018&r1=1617017&r2=1617018&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Sat Aug 9 21:20:50 2014
@@ -1,6 +1,10 @@
-*- coding: utf-8 -*-
Changes with Apache 2.5.0
+ *) mod_ratelimit: Drop severity of AH01455 and AH01457 (ap_pass_brigade
+ failed) messages from ERROR to TRACE1. Other filters do not bother
+ re-reporting failures from lower level filters. PR56832. [Eric Covener]
+
*) mod_proxy_http: Proxy responses with error status and
"ProxyErrorOverride On" hang until proxy timeout.
PR53420 [Rainer Jung]
Modified: httpd/httpd/trunk/modules/filters/mod_ratelimit.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_ratelimit.c?rev=1617018&r1=1617017&r2=1617018&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_ratelimit.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_ratelimit.c Sat Aug 9 21:20:50 2014
@@ -145,7 +145,7 @@ rate_limit_filter(ap_filter_t *f, apr_bu
if (rv != APR_SUCCESS) {
ctx->state = RATE_ERROR;
- ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f->r, APLOGNO(01455)
+ ap_log_rerror(APLOG_MARK, APLOG_TRACE1, rv, f->r, APLOGNO(01455)
"rl: full speed brigade pass failed.");
}
}
@@ -217,7 +217,7 @@ rate_limit_filter(ap_filter_t *f, apr_bu
if (rv != APR_SUCCESS) {
ctx->state = RATE_ERROR;
- ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, f->r, APLOGNO(01457)
+ ap_log_rerror(APLOG_MARK, APLOG_TRACE1, rv, f->r, APLOGNO(01457)
"rl: brigade pass failed.");
break;
}
Re: svn commit: r1617018 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_ratelimit.c
Posted by Eric Covener <co...@gmail.com>.
On Sun, Aug 31, 2014 at 3:47 AM, Christophe JAILLET
<ch...@wanadoo.fr> wrote:
> Hi,
>
> Other places of the code also seem to log message in the same kind of
> condition at either APLOG_DEBUG, APLOG_ERR or APLOG_INFO level.
> Should they be updated as well?
>
>
> The following use APLOG_DEBUG:
> ./server/core.c:4622
> ap_pass_brigade_fchk()
> ./modules/isapi.c
> ./modules/filters/mod_ext_filter.c:880
> ./modules/filters/mod_reflector.c:157
>
> The following use APLOG_ERR:
> ./modules/arch/netware/mod_nw_ssl.c:1201
> ./modules/generators/mod_cgid.c:1651
> ./modules/generators/mod_asis.c:100
> ./modules/test/mod_dialup.c:84
> ./modules/proxy/mod_proxy_wstunnel.c:289
> ./modules/proxy/proxy_util.c:3571
> ./modules/proxy/mod_proxy_connect.c:171
> ./modules/proxy/mod_proxy_fdpass.c:211
>
> The following use APLOG_INFO:
> ./modules/echo/mod_echo.c:179
> ./modules/http/http_filters.c:1617
>
It seems like of the above, the _filters_ that do report are already
at DEBUG (I spot-checked some more popular filters before) -- all of
the ones at APLOG_ERR are handlers at the top of the stack just
reporting once. I am not seeing any that stick out like ratelimit.
> Best regards,
> CJ
>
> Le 09/08/2014 23:20, covener@apache.org a écrit :
>>
>> Author: covener
>> Date: Sat Aug 9 21:20:50 2014
>> New Revision: 1617018
>>
>> URL: http://svn.apache.org/r1617018
>> Changes with Apache 2.5.0
>> + *) mod_ratelimit: Drop severity of AH01455 and AH01457
>> (ap_pass_brigade
>> + failed) messages from ERROR to TRACE1. Other filters do not bother
>> + re-reporting failures from lower level filters. PR56832. [Eric
>> Covener]
>> +
>
>
--
Eric Covener
covener@gmail.com
Re: svn commit: r1617018 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_ratelimit.c
Posted by Christophe JAILLET <ch...@wanadoo.fr>.
Hi,
Other places of the code also seem to log message in the same kind of
condition at either APLOG_DEBUG, APLOG_ERR or APLOG_INFO level.
Should they be updated as well?
The following use APLOG_DEBUG:
./server/core.c:4622
ap_pass_brigade_fchk()
./modules/isapi.c
./modules/filters/mod_ext_filter.c:880
./modules/filters/mod_reflector.c:157
The following use APLOG_ERR:
./modules/arch/netware/mod_nw_ssl.c:1201
./modules/generators/mod_cgid.c:1651
./modules/generators/mod_asis.c:100
./modules/test/mod_dialup.c:84
./modules/proxy/mod_proxy_wstunnel.c:289
./modules/proxy/proxy_util.c:3571
./modules/proxy/mod_proxy_connect.c:171
./modules/proxy/mod_proxy_fdpass.c:211
The following use APLOG_INFO:
./modules/echo/mod_echo.c:179
./modules/http/http_filters.c:1617
Best regards,
CJ
Le 09/08/2014 23:20, covener@apache.org a écrit :
> Author: covener
> Date: Sat Aug 9 21:20:50 2014
> New Revision: 1617018
>
> URL: http://svn.apache.org/r1617018
> Changes with Apache 2.5.0
>
> + *) mod_ratelimit: Drop severity of AH01455 and AH01457 (ap_pass_brigade
> + failed) messages from ERROR to TRACE1. Other filters do not bother
> + re-reporting failures from lower level filters. PR56832. [Eric Covener]
> +