[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #885: feat: add rocksdb write_options to configuration

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #885:
URL: https://github.com/apache/incubator-kvrocks/pull/885#discussion_r975386657


##########
src/config.cc:
##########
@@ -603,6 +611,9 @@ Status Config::finish() {
     auto s = rocksdb::Env::Default()->CreateDirIfMissing(name);
     if (!s.ok()) return Status(Status::NotOK, s.ToString());
   }
+  if (!slaveof_.empty() && RocksDB.write_options.disable_WAL) {
+    return Status(Status::NotOK, "cannot disable the WAL while using Master-Slave replication");
+  }

Review Comment:
   I think we should check this in the `slaveof` command.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org