You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "buraksenn (via GitHub)" <gi...@apache.org> on 2026/03/26 11:50:56 UTC

[PR] Minor: compute qualify window expressions only when QUALIFY clause is present [datafusion]

buraksenn opened a new pull request, #21173:
URL: https://github.com/apache/datafusion/pull/21173

   ## Which issue does this PR close?
   Does not close but related #608
   
   
   ## Rationale for this change
   Followup to #20963
   @jonahgao had a feedback in https://github.com/apache/datafusion/pull/20963#discussion_r2988447937 to try to find qualify only if we are inside QUALIFY block. I did not think it was this minor so thought followup would be better but this is simply moving to if block to prevent unnecessary computation
   
   
   ## What changes are included in this PR?
   Move `qualify_window_func_exprs` computation inside the QUALIFY block
   
   ## Are these changes tested?
   Covered by existing tests from #20963.
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Minor: compute qualify window expressions only when QUALIFY clause is present [datafusion]

Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao merged PR #21173:
URL: https://github.com/apache/datafusion/pull/21173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org