You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/23 17:12:24 UTC
[GitHub] [thrift] belugabehr opened a new pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
belugabehr opened a new pull request #2266:
URL: https://github.com/apache/thrift/pull/2266
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x ] Did you squash your changes to a single commit? (not required, but preferred)
- [X] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [X] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2266:
URL: https://github.com/apache/thrift/pull/2266#issuecomment-772570129
OK. Looks like there was a lag. All good now.
I ran into some hardship recently trying to debug an application build on Thrift server. I have some ideas for making it more debug-able, but need this in first and then can build on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2266:
URL: https://github.com/apache/thrift/pull/2266#issuecomment-750319912
@Jens-G Thank you for your interest. I believe there were some comment about moving the back-off functionality to the client code, which is not inappropriate, but I have not yet had the time to implement.
Happy to get this part in first if that's OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr closed pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2266:
URL: https://github.com/apache/thrift/pull/2266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2266:
URL: https://github.com/apache/thrift/pull/2266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2266:
URL: https://github.com/apache/thrift/pull/2266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2266:
URL: https://github.com/apache/thrift/pull/2266#issuecomment-772713185
@Jens-G Should be good to go now. C++ failures only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2266:
URL: https://github.com/apache/thrift/pull/2266#issuecomment-750305052
@belugabehr There seem no objections from anyone. What about triggering the CI again and commit if all is green?
@ java devs: Any comments on this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2266: THRIFT-5297: Improve TThreadPoolServer Handling of Incoming Connections
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2266:
URL: https://github.com/apache/thrift/pull/2266#issuecomment-772569168
@Jens-G Any ideas on how to kick off the automated build/test suite?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org