You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Alexander Edge (Jira)" <ji...@apache.org> on 2020/02/27 11:35:00 UTC

[jira] [Updated] (THRIFT-5121) Logic bug in TMultiplexedProcessor – Swift

     [ https://issues.apache.org/jira/browse/THRIFT-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Edge updated THRIFT-5121:
-----------------------------------
    Description: 
A previous patch ([https://github.com/apache/thrift/pull/2002]) for https://issues.apache.org/jira/browse/THRIFT-5084 added multiplexing support but contained a logical error when checking the message type. It should allow `oneway` and `call` message types and reject all others, but it rejected `oneway` and `call` messages and accepted all others.

 

I've fixed the bug and updated the unit tests. GitHub PR linked. My apologies for any inconvenience caused.

  was:
A previous patch (https://github.com/apache/thrift/pull/2002) for https://issues.apache.org/jira/browse/THRIFT-5084 added multiplexing support but contained a logical error when checking the message type. It should allow `oneway` and `call` message types and reject all others, but it rejected `oneway` and `call` messages and accepted all others.

 

I have created a PR to fix the bug.


> Logic bug in TMultiplexedProcessor – Swift
> ------------------------------------------
>
>                 Key: THRIFT-5121
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5121
>             Project: Thrift
>          Issue Type: Bug
>          Components: Swift - Library
>            Reporter: Alexander Edge
>            Assignee: Alexander Edge
>            Priority: Major
>              Labels: multiplexing
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A previous patch ([https://github.com/apache/thrift/pull/2002]) for https://issues.apache.org/jira/browse/THRIFT-5084 added multiplexing support but contained a logical error when checking the message type. It should allow `oneway` and `call` message types and reject all others, but it rejected `oneway` and `call` messages and accepted all others.
>  
> I've fixed the bug and updated the unit tests. GitHub PR linked. My apologies for any inconvenience caused.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)