You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/18 15:54:43 UTC

[GitHub] sergey-chugunov-1985 edited a comment on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites

sergey-chugunov-1985 edited a comment on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites
URL: https://github.com/apache/ignite/pull/5814#issuecomment-455593484
 
 
   I really like how zk-related tests are split from a huge class into a separate classes each testing specific aspects of functionality.
   
   But I have a suggestion about naming of new ZookeeperDiscovery test classes. What if we include a name of major functionality covered by each class?
   
   I would suggest the following changes:
   - ZookeeperDiscoverySpiTest -> ZookeeperDiscoveryMiscTest
   - Test2 -> SegmentationAndConnectionRestoreTest
   - Test3 -> ConcurrectStartAndStartStopTest
   - Test4 -> TopologyChangeAndReconnectTest
   - Test5 -> CommunicationFailureTest
   - Test6 -> ClientDisconnectTest
   - Test7 -> SplitBrainTest
   - Test8 -> CustomEventsTest

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services