You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/14 03:03:27 UTC
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #4531: [HUDI-3191][Stacked on 4520] Rebasing Hive's FileInputFormat onto `AbstractHoodieTableFileIndex`
alexeykudinkin commented on a change in pull request #4531:
URL: https://github.com/apache/hudi/pull/4531#discussion_r784477274
##########
File path: hudi-common/pom.xml
##########
@@ -97,6 +156,13 @@
</build>
<dependencies>
+ <!-- Scala -->
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-library</artifactId>
+ <version>${scala.version}</version>
+ </dependency>
+
Review comment:
> I'm not sure if it's a good idea to have scala deps in hudi-common.
Yeah, this is a by-product of keeping this FileIndex in Scala for now. There's also no other module shared by both Spark and Hive unfortunately.
HUDI-3239 would actually resolve this converting it to Java.
> Then there will be hudi-common_2.11 and hudi-common_2.12, which is not really necessary.
This is not necessary -- since we don't depend on any divergent behavior here
##########
File path: hudi-common/pom.xml
##########
@@ -97,6 +156,13 @@
</build>
<dependencies>
+ <!-- Scala -->
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-library</artifactId>
+ <version>${scala.version}</version>
+ </dependency>
+
Review comment:
> I'm not sure if it's a good idea to have scala deps in hudi-common.
Yeah, this is a by-product of keeping this FileIndex in Scala for now. There's also no other module shared by both Spark and Hive unfortunately.
HUDI-3239 would actually resolve this converting it to Java.
> Then there will be hudi-common_2.11 and hudi-common_2.12, which is not really necessary.
This is not necessary -- since we don't depend on any diverging behavior here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org