You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/01 09:24:44 UTC
[GitHub] [arrow] joosthooz commented on a change in pull request #11810: ARROW-9648: Added compression level parameter to LZ4_FRAME compression codec.
joosthooz commented on a change in pull request #11810:
URL: https://github.com/apache/arrow/pull/11810#discussion_r759996881
##########
File path: cpp/src/arrow/util/compression_test.cc
##########
@@ -375,10 +375,11 @@ TEST(TestCodecMisc, SpecifyCompressionLevel) {
bool expect_success;
};
constexpr CombinationOption combinations[] = {
- {Compression::GZIP, 2, true}, {Compression::BROTLI, 10, true},
- {Compression::ZSTD, 4, true}, {Compression::LZ4, -10, false},
- {Compression::LZO, -22, false}, {Compression::UNCOMPRESSED, 10, false},
- {Compression::SNAPPY, 16, false}, {Compression::GZIP, -992, false}};
+ {Compression::GZIP, 2, true}, {Compression::BROTLI, 10, true},
+ {Compression::ZSTD, 4, true}, {Compression::LZ4, -10, false},
+ {Compression::LZO, -22, false}, {Compression::UNCOMPRESSED, 10, false},
+ {Compression::SNAPPY, 16, false}, {Compression::GZIP, -992, false},
+ {Compression::LZ4_FRAMED, 9, true}, {Compression::LZ4_FRAMED, -99, false}};
Review comment:
Fixed, and also removed the testcase with invalid value, because LZ4 will rectify that internally (and not fail)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org