[jira] [Commented] (ROCKETMQ-75) RemotingCommand header decoding swallows exceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847887#comment-15847887 ] 

ASF GitHub Bot commented on ROCKETMQ-75:
----------------------------------------

Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/51
  
    Hi @shroman ,
    
    IMO, it could be better that one PR/issue one thing, can we move `makeCustomHeaderToNet` to another issue, and make `makeCustomHeaderToNet ()` private will bring some reflection code, I think it's not very reasonable.


> RemotingCommand header decoding swallows exceptions
> ---------------------------------------------------
>
>                 Key: ROCKETMQ-75
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-75
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> {{RemotingCommand}} header decoding swallows exceptions, which is ok if you want to skip unparseable fields, but then logging is needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)