[GitHub] [pulsar] kimcs commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system

[GitBox <gi...@apache.org>]

kimcs commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system
URL: https://github.com/apache/pulsar/pull/4166#issuecomment-488693598
 
 
   @sijie I attempted to use the pulsar-client-all shaded jar, and had success with some minor modifications, they are now what is included in this PR. If you merge this PR it will allow the use of officially released pulsar client shaded jar with the java-module-system.
   
   However, I do believe that depending on a 25+MB shaded jar is sub-optimal. I have already optimised my java application docker-images and have them at around 55MB total before including this jar. I believe that in order for Pulsar to be a fully java-module-system compatible client, there need to be some more work to avoid the split package issue that is now inherent in the pulsar-client libraries.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services