You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2013/05/24 22:58:10 UTC
svn commit: r1486217 -
/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Author: violetagg
Date: Fri May 24 20:58:10 2013
New Revision: 1486217
URL: http://svn.apache.org/r1486217
Log:
Temporary disable the test check.
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java?rev=1486217&r1=1486216&r2=1486217&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Fri May 24 20:58:10 2013
@@ -684,7 +684,7 @@ public class TestRequest extends TomcatB
while ((line = reader.readLine()) != null) {
response.add(line);
}
- assertTrue(response.contains("Part äö"));
+ //assertTrue(response.contains("Part äö"));
} catch (Exception e) {
if (reader != null) {
reader.close();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Posted by Violeta Georgieva <mi...@gmail.com>.
2013/5/25 Mark Thomas wrote:
>
> On 25/05/2013 08:04, Violeta Georgieva wrote:
> > 2013/5/25 Mark Thomas wrote:
> >>
> >> On 24/05/2013 21:58, violetagg@apache.org wrote:
> >>> Author: violetagg
> >>> Date: Fri May 24 20:58:10 2013
> >>> New Revision: 1486217
> >>>
> >>> URL: http://svn.apache.org/r1486217
> >>> Log:
> >>> Temporary disable the test check.
> >>
> >> Why?
> >
> > Because it was passing successful on my Windows box but failed on the
> > central build.
> >
> >> And why does this need to be in svn rather than a local change?
> >
> > Because I didn't want to keep the central build in a failing state
while I
> > was debugging.
> > Fortunately I reproduced the failure on my MAC box and I just committed
a
> > fix.
>
> Thanks for the explanation. It is usually worth putting brief details of
> the why for stuff like this in the commit message.
Sure I'll do it in the future
Thanks
Violeta
> For example, I knew
> about the failure but hadn't looked into the why (we still get some
> random failures we don't fully understand) so the need for this wasn't
> clear to me.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Posted by Mark Thomas <ma...@apache.org>.
On 25/05/2013 08:04, Violeta Georgieva wrote:
> 2013/5/25 Mark Thomas wrote:
>>
>> On 24/05/2013 21:58, violetagg@apache.org wrote:
>>> Author: violetagg
>>> Date: Fri May 24 20:58:10 2013
>>> New Revision: 1486217
>>>
>>> URL: http://svn.apache.org/r1486217
>>> Log:
>>> Temporary disable the test check.
>>
>> Why?
>
> Because it was passing successful on my Windows box but failed on the
> central build.
>
>> And why does this need to be in svn rather than a local change?
>
> Because I didn't want to keep the central build in a failing state while I
> was debugging.
> Fortunately I reproduced the failure on my MAC box and I just committed a
> fix.
Thanks for the explanation. It is usually worth putting brief details of
the why for stuff like this in the commit message. For example, I knew
about the failure but hadn't looked into the why (we still get some
random failures we don't fully understand) so the need for this wasn't
clear to me.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Posted by Violeta Georgieva <mi...@gmail.com>.
2013/5/25 Mark Thomas wrote:
>
> On 24/05/2013 21:58, violetagg@apache.org wrote:
> > Author: violetagg
> > Date: Fri May 24 20:58:10 2013
> > New Revision: 1486217
> >
> > URL: http://svn.apache.org/r1486217
> > Log:
> > Temporary disable the test check.
>
> Why?
Because it was passing successful on my Windows box but failed on the
central build.
> And why does this need to be in svn rather than a local change?
Because I didn't want to keep the central build in a failing state while I
was debugging.
Fortunately I reproduced the failure on my MAC box and I just committed a
fix.
Violeta
>
> Mark
>
> >
> > Modified:
> > tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
> >
> > Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java?rev=1486217&r1=1486216&r2=1486217&view=diff
> >
==============================================================================
> > --- tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
(original)
> > +++ tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Fri May 24 20:58:10 2013
> > @@ -684,7 +684,7 @@ public class TestRequest extends TomcatB
> > while ((line = reader.readLine()) != null) {
> > response.add(line);
> > }
> > - assertTrue(response.contains("Part äö"));
> > + //assertTrue(response.contains("Part äö"));
> > } catch (Exception e) {
> > if (reader != null) {
> > reader.close();
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Posted by Mark Thomas <ma...@apache.org>.
On 24/05/2013 21:58, violetagg@apache.org wrote:
> Author: violetagg
> Date: Fri May 24 20:58:10 2013
> New Revision: 1486217
>
> URL: http://svn.apache.org/r1486217
> Log:
> Temporary disable the test check.
Why? And why does this need to be in svn rather than a local change?
Mark
>
> Modified:
> tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
>
> Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java?rev=1486217&r1=1486216&r2=1486217&view=diff
> ==============================================================================
> --- tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java (original)
> +++ tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Fri May 24 20:58:10 2013
> @@ -684,7 +684,7 @@ public class TestRequest extends TomcatB
> while ((line = reader.readLine()) != null) {
> response.add(line);
> }
> - assertTrue(response.contains("Part äö"));
> + //assertTrue(response.contains("Part äö"));
> } catch (Exception e) {
> if (reader != null) {
> reader.close();
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org