You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "inochisa (via GitHub)" <gi...@apache.org> on 2024/04/28 06:13:17 UTC

[PR] arch/risc-v: remove macro test for ipi function [nuttx]

inochisa opened a new pull request, #12242:
URL: https://github.com/apache/nuttx/pull/12242

   Remove the check on RISCV_IPI in riscv_ipi_send/clear and let build fail if RISCV_IPI is not defined.
   
   Fixup: 4f63ca1418 ("arch/risc-v: unfiy IPI access)
   
   This fixed https://github.com/apache/nuttx/pull/12178#discussion_r1581985451
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/risc-v: remove macro test for ipi function [nuttx]

Posted by "inochisa (via GitHub)" <gi...@apache.org>.
inochisa commented on PR #12242:
URL: https://github.com/apache/nuttx/pull/12242#issuecomment-2081783598

   Close this PR and favor the new PR  #12250 implement of `sbi_ipi_send`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/risc-v: remove macro test for ipi function [nuttx]

Posted by "inochisa (via GitHub)" <gi...@apache.org>.
inochisa commented on PR #12242:
URL: https://github.com/apache/nuttx/pull/12242#issuecomment-2081412841

   > jh7110_irq
   
   Yes, it is a surprise for me. I think the original patch just forgot to add the definition. I will try to fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/risc-v: remove macro test for ipi function [nuttx]

Posted by "inochisa (via GitHub)" <gi...@apache.org>.
inochisa closed pull request #12242: arch/risc-v: remove macro test for ipi function
URL: https://github.com/apache/nuttx/pull/12242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/risc-v: remove macro test for ipi function [nuttx]

Posted by "inochisa (via GitHub)" <gi...@apache.org>.
inochisa commented on PR #12242:
URL: https://github.com/apache/nuttx/pull/12242#issuecomment-2081414373

   OK, after some searching, it seems I need to implement sbi_ipi_send for bl808 and jh7110, the only support S-mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/risc-v: remove macro test for ipi function [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #12242:
URL: https://github.com/apache/nuttx/pull/12242#issuecomment-2081408905

   Ok, this change catches one place which forget to modify in original patch:
   ```
   ====================================================================================
   Configuration/Tool: star64/nsh
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Building NuttX...
   In file included from chip/jh7110_irq.c:35:
   /github/workspace/sources/nuttx/arch/risc-v/src/common/riscv_ipi.h: In function 'riscv_ipi_send':
   Error: /github/workspace/sources/nuttx/arch/risc-v/src/common/riscv_ipi.h:37:26: error: 'RISCV_IPI' undeclared (first use in this function)
      37 |   putreg32(1, (uintptr_t)RISCV_IPI + (4 * cpu));
         |                          ^~~~~~~~~
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org