You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Matthew Hatem <mh...@gmail.com> on 2011/10/18 19:56:30 UTC
Review Request: Containers should be able to override a subset of the rpc
handlers of the actions feature.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter and Jason Chiang.
Summary
-------
Containers should be able to override a subset of the rpc handlers of the actions feature.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1183019
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1183019
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1183019
Diff: https://reviews.apache.org/r/2424/diff
Testing
-------
All unit tests pass.
Thanks,
Matthew
Re: Review Request: Containers should be able to override a subset of the
rpc handlers of the actions feature.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/#review2657
-----------------------------------------------------------
Ship it!
lgtm
- Dan
On 2011-10-18 19:16:00, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2424/
> -----------------------------------------------------------
>
> (Updated 2011-10-18 19:16:00)
>
>
> Review request for shindig, Ryan Baxter and Jason Chiang.
>
>
> Summary
> -------
>
> Containers should be able to override a subset of the rpc handlers of the actions feature.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1183019
>
> Diff: https://reviews.apache.org/r/2424/diff
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Containers should be able to override a subset of the
rpc handlers of the actions feature.
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-10-19 01:38:51, Ryan Baxter wrote:
> > LGTM. Matt please create a JIRA and attach the patch to it.
I found the JIRA. Committed revision 1186350.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/#review2663
-----------------------------------------------------------
On 2011-10-18 19:16:00, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2424/
> -----------------------------------------------------------
>
> (Updated 2011-10-18 19:16:00)
>
>
> Review request for shindig, Ryan Baxter and Jason Chiang.
>
>
> Summary
> -------
>
> Containers should be able to override a subset of the rpc handlers of the actions feature.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1183019
>
> Diff: https://reviews.apache.org/r/2424/diff
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Containers should be able to override a subset of the
rpc handlers of the actions feature.
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/#review2663
-----------------------------------------------------------
Ship it!
LGTM. Matt please create a JIRA and attach the patch to it.
- Ryan
On 2011-10-18 19:16:00, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2424/
> -----------------------------------------------------------
>
> (Updated 2011-10-18 19:16:00)
>
>
> Review request for shindig, Ryan Baxter and Jason Chiang.
>
>
> Summary
> -------
>
> Containers should be able to override a subset of the rpc handlers of the actions feature.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1183019
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1183019
>
> Diff: https://reviews.apache.org/r/2424/diff
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Containers should be able to override a subset of the
rpc handlers of the actions feature.
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/
-----------------------------------------------------------
(Updated 2011-10-18 19:16:00.617784)
Review request for shindig, Ryan Baxter and Jason Chiang.
Changes
-------
Updated diff based on feedback.
Summary
-------
Containers should be able to override a subset of the rpc handlers of the actions feature.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1183019
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1183019
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1183019
Diff: https://reviews.apache.org/r/2424/diff
Testing
-------
All unit tests pass.
Thanks,
Matthew