You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/10/11 15:53:08 UTC
[PR] Support dynamic update ThreadPool [incubator-uniffle]
maobaolong opened a new pull request, #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2408849498
The failed test is not related to this PR.
```
org.apache.uniffle.common.exception.RssFetchFailedException: Get shuffle result is failed for appId[case1], shuffleId[0]
at org.apache.uniffle.client.impl.ShuffleWriteClientImpl.getShuffleResult(ShuffleWriteClientImpl.java:830)
at org.apache.uniffle.test.QuorumTest.case1(QuorumTest.java:393)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server,coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2415647081
@zuston Thanks for your review and the comment, addressed it by new commit, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2168: [#2169] feat(server/coordinator): Support dynamic update ThreadPool
URL: https://github.com/apache/incubator-uniffle/pull/2168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2407776098
## Test Results
2 926 files ±0 2 926 suites ±0 5h 57m 44s :stopwatch: + 1m 58s
1 041 tests ±0 1 039 :white_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
13 003 runs ±0 12 973 :white_check_mark: ±0 30 :zzz: ±0 0 :x: ±0
Results for commit 30f73446. ± Comparison against base commit be23f613.
[test-results]:data:application/gzip;base64,H4sIALJVCWcC/02Myw6DIBBFf8Ww7mKACY/+TKM8ElKVBmFl+u9F64PlOTP3rMSH0S3k2THNxKMjSwm5ZVtSn0OcN0NRYFX1nrcPCkhPfC3FmN1xfbt3+Gy7S/g+jFXAJVxKMR0mlXmvcgB+4FVlWt7uX+Xnpq3u3EZNnKaQKxAOXnJEoSkqaq0TelBmsCB7gwyMZ0oidWog3x9mx1jyFAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server,coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on code in PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#discussion_r1802242322
##########
common/src/main/java/org/apache/uniffle/common/executor/ThreadPoolManager.java:
##########
@@ -90,36 +99,145 @@ public static ThreadPoolExecutor newThreadPool(
BlockingQueue<Runnable> workQueue,
ThreadFactory threadFactory,
RejectedExecutionHandler handler) {
+ return newThreadPool(
+ name,
+ () -> corePoolSize,
+ () -> maximumPoolSize,
+ () -> keepAliveTime,
+ unit,
+ workQueue,
+ threadFactory,
+ handler);
+ }
+
+ /**
+ * Add a thread pool.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param unit the unit
+ * @param workQueue the work queue
+ * @param threadFactory the thread factory
+ * @return the registered thread pool
+ */
+ public static ThreadPoolExecutor newThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ TimeUnit unit,
+ BlockingQueue<Runnable> workQueue,
+ ThreadFactory threadFactory) {
ThreadPoolExecutor threadPoolExecutor =
new ThreadPoolExecutor(
- corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory, handler);
- registerThreadPool(name, corePoolSize, maximumPoolSize, keepAliveTime, threadPoolExecutor);
+ corePoolSizeSupplier.get(),
+ maximumPoolSizeSupplier.get(),
+ keepAliveTimeSupplier.get(),
+ unit,
+ workQueue,
+ threadFactory);
+ registerThreadPool(
+ name,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ () -> keepAliveTimeSupplier.get() * unit.toMillis(1),
+ threadPoolExecutor);
return threadPoolExecutor;
}
/**
- * Register a thread pool to THREAD_POOL_MAP.
+ * Add a thread pool.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param unit the unit
+ * @param workQueue the work queue
+ * @param threadFactory the thread factory
+ * @param handler the handler to use when execution is blocked because the thread bounds and queue
+ * capacities are reached
+ * @return the registered thread pool
+ */
+ public static ThreadPoolExecutor newThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ TimeUnit unit,
+ BlockingQueue<Runnable> workQueue,
+ ThreadFactory threadFactory,
+ RejectedExecutionHandler handler) {
+ ThreadPoolExecutor threadPoolExecutor =
+ new ThreadPoolExecutor(
+ corePoolSizeSupplier.get(),
+ maximumPoolSizeSupplier.get(),
+ keepAliveTimeSupplier.get(),
+ unit,
+ workQueue,
+ threadFactory,
+ handler);
+ registerThreadPool(
+ name,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ keepAliveTimeSupplier,
+ threadPoolExecutor);
+ return threadPoolExecutor;
+ }
+
+ /**
+ * Add a thread pool.
*
* @param name the name of the thread pool
- * @param corePoolSize the core pool size supplier
- * @param maximumPoolSize the maximum pool size supplier
- * @param keepAliveTime the keep alive time supplier
+ * @param corePoolSize the core pool size
+ * @param maximumPoolSize the maximum pool size
+ * @param keepAliveTime the keep alive time
* @param threadPoolExecutor the thread pool which will be registered
+ * @return the registered thread pool
*/
+ @VisibleForTesting
public static void registerThreadPool(
String name,
int corePoolSize,
int maximumPoolSize,
long keepAliveTime,
ThreadPoolExecutor threadPoolExecutor) {
+ registerThreadPool(
+ name, () -> corePoolSize, () -> maximumPoolSize, () -> keepAliveTime, threadPoolExecutor);
+ }
+
+ /**
+ * Register a thread pool to THREAD_POOL_MAP.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param threadPoolExecutor the thread pool which will be registered
+ */
+ public static void registerThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ ThreadPoolExecutor threadPoolExecutor) {
THREAD_POOL_MAP.put(
- threadPoolExecutor, new MeasurableThreadPoolExecutor(name, threadPoolExecutor));
+ threadPoolExecutor,
+ new MeasurableThreadPoolExecutor(
+ name,
+ threadPoolExecutor,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ keepAliveTimeSupplier));
LOG.info(
"{} thread pool, core size:{}, max size:{}, keep alive time:{}",
name,
- corePoolSize,
- maximumPoolSize,
- keepAliveTime);
+ corePoolSizeSupplier,
Review Comment:
corePoolSizeSupplier.get() ? @maobaolong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server,coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on code in PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#discussion_r1802286914
##########
common/src/main/java/org/apache/uniffle/common/executor/ThreadPoolManager.java:
##########
@@ -90,36 +99,145 @@ public static ThreadPoolExecutor newThreadPool(
BlockingQueue<Runnable> workQueue,
ThreadFactory threadFactory,
RejectedExecutionHandler handler) {
+ return newThreadPool(
+ name,
+ () -> corePoolSize,
+ () -> maximumPoolSize,
+ () -> keepAliveTime,
+ unit,
+ workQueue,
+ threadFactory,
+ handler);
+ }
+
+ /**
+ * Add a thread pool.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param unit the unit
+ * @param workQueue the work queue
+ * @param threadFactory the thread factory
+ * @return the registered thread pool
+ */
+ public static ThreadPoolExecutor newThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ TimeUnit unit,
+ BlockingQueue<Runnable> workQueue,
+ ThreadFactory threadFactory) {
ThreadPoolExecutor threadPoolExecutor =
new ThreadPoolExecutor(
- corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory, handler);
- registerThreadPool(name, corePoolSize, maximumPoolSize, keepAliveTime, threadPoolExecutor);
+ corePoolSizeSupplier.get(),
+ maximumPoolSizeSupplier.get(),
+ keepAliveTimeSupplier.get(),
+ unit,
+ workQueue,
+ threadFactory);
+ registerThreadPool(
+ name,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ () -> keepAliveTimeSupplier.get() * unit.toMillis(1),
+ threadPoolExecutor);
return threadPoolExecutor;
}
/**
- * Register a thread pool to THREAD_POOL_MAP.
+ * Add a thread pool.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param unit the unit
+ * @param workQueue the work queue
+ * @param threadFactory the thread factory
+ * @param handler the handler to use when execution is blocked because the thread bounds and queue
+ * capacities are reached
+ * @return the registered thread pool
+ */
+ public static ThreadPoolExecutor newThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ TimeUnit unit,
+ BlockingQueue<Runnable> workQueue,
+ ThreadFactory threadFactory,
+ RejectedExecutionHandler handler) {
+ ThreadPoolExecutor threadPoolExecutor =
+ new ThreadPoolExecutor(
+ corePoolSizeSupplier.get(),
+ maximumPoolSizeSupplier.get(),
+ keepAliveTimeSupplier.get(),
+ unit,
+ workQueue,
+ threadFactory,
+ handler);
+ registerThreadPool(
+ name,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ keepAliveTimeSupplier,
+ threadPoolExecutor);
+ return threadPoolExecutor;
+ }
+
+ /**
+ * Add a thread pool.
*
* @param name the name of the thread pool
- * @param corePoolSize the core pool size supplier
- * @param maximumPoolSize the maximum pool size supplier
- * @param keepAliveTime the keep alive time supplier
+ * @param corePoolSize the core pool size
+ * @param maximumPoolSize the maximum pool size
+ * @param keepAliveTime the keep alive time
* @param threadPoolExecutor the thread pool which will be registered
+ * @return the registered thread pool
*/
+ @VisibleForTesting
public static void registerThreadPool(
String name,
int corePoolSize,
int maximumPoolSize,
long keepAliveTime,
ThreadPoolExecutor threadPoolExecutor) {
+ registerThreadPool(
+ name, () -> corePoolSize, () -> maximumPoolSize, () -> keepAliveTime, threadPoolExecutor);
+ }
+
+ /**
+ * Register a thread pool to THREAD_POOL_MAP.
+ *
+ * @param name the name of the thread pool
+ * @param corePoolSizeSupplier the core pool size supplier
+ * @param maximumPoolSizeSupplier the maximum pool size supplier
+ * @param keepAliveTimeSupplier the keep alive time supplier
+ * @param threadPoolExecutor the thread pool which will be registered
+ */
+ public static void registerThreadPool(
+ String name,
+ Supplier<Integer> corePoolSizeSupplier,
+ Supplier<Integer> maximumPoolSizeSupplier,
+ Supplier<Long> keepAliveTimeSupplier,
+ ThreadPoolExecutor threadPoolExecutor) {
THREAD_POOL_MAP.put(
- threadPoolExecutor, new MeasurableThreadPoolExecutor(name, threadPoolExecutor));
+ threadPoolExecutor,
+ new MeasurableThreadPoolExecutor(
+ name,
+ threadPoolExecutor,
+ corePoolSizeSupplier,
+ maximumPoolSizeSupplier,
+ keepAliveTimeSupplier));
LOG.info(
"{} thread pool, core size:{}, max size:{}, keep alive time:{}",
name,
- corePoolSize,
- maximumPoolSize,
- keepAliveTime);
+ corePoolSizeSupplier,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2413562673
Flaky Test.
```
[INFO] Running org.apache.uniffle.test.QuorumTest
Error: Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 228.682 s <<< FAILURE! - in org.apache.uniffle.test.QuorumTest
Error: case8 Time elapsed: 184.163 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
at org.apache.uniffle.test.QuorumTest.case8(QuorumTest.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2168: [#2169] feat(server/coordinator): Support dynamic update ThreadPool
URL: https://github.com/apache/incubator-uniffle/pull/2168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2408586309
@zuston This is a enhance of thread pool manager, would you like to take a look at this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server/coordinator): Support dynamic update ThreadPool [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168#issuecomment-2413235480
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `51.25000%` with `39 lines` in your changes missing coverage. Please review.
> Project coverage is 53.01%. Comparing base [(`78fe934`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/78fe934ef7c96e7135a1b3087a5d00567d268dcb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ca85e9f`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ca85e9fc1a1a571f5dc6677c772d1b2ca41733f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/uniffle/common/executor/ThreadPoolManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Funiffle%2Fcommon%2Fexecutor%2FThreadPoolManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9leGVjdXRvci9UaHJlYWRQb29sTWFuYWdlci5qYXZh) | 45.45% | [36 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/uniffle/common/rpc/GrpcServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Funiffle%2Fcommon%2Frpc%2FGrpcServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9ycGMvR3JwY1NlcnZlci5qYXZh) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
============================================
+ Coverage 52.86% 53.01% +0.14%
+ Complexity 3385 3007 -378
============================================
Files 517 461 -56
Lines 28208 24193 -4015
Branches 2633 2309 -324
============================================
- Hits 14913 12825 -2088
+ Misses 12332 10495 -1837
+ Partials 963 873 -90
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2168?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2169] feat(server)(coordinator): Support dynamic thread number update about ThreadPool [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2168:
URL: https://github.com/apache/incubator-uniffle/pull/2168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org