You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yakov Kopel (JIRA)" <ji...@apache.org> on 2012/06/28 08:37:42 UTC

[jira] [Created] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Yakov Kopel created TS-1322:
-------------------------------

             Summary: CONNECT to parent proxy has URL with a trailing slash
                 Key: TS-1322
                 URL: https://issues.apache.org/jira/browse/TS-1322
             Project: Traffic Server
          Issue Type: Bug
          Components: HTTP
            Reporter: Yakov Kopel
             Fix For: 3.2.0


I want to redirect a CONNECT request to parent proxy.
I'm doing it with the TSHttpTxnParentProxySet API.

The problem is that the URL that the TS is setting is invalid:
	
	CONNECT www.example.com:443/ HTTP/1.1
	Host: www.example.com:443

The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).

Solution:
	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
	While" authority" is the hostaname.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403151#comment-13403151 ] 

Leif Hedstrom commented on TS-1322:
-----------------------------------

There was a bug for this already, TS-920. :). I've marked that as a duplicate of this one, since this has more details.

Thanks.
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.2.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415915#comment-13415915 ] 

Leif Hedstrom commented on TS-1322:
-----------------------------------

I'll have to read the code more careful, but can we be sure there's a trailing '/' in the case where you remove it?
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.3.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415950#comment-13415950 ] 

Leif Hedstrom commented on TS-1322:
-----------------------------------

Makes sense. I assume we can trust the rest of the URI to be empty here (e.g. the path, query args etc.).
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.3.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403021#comment-13403021 ] 

Yakov Kopel commented on TS-1322:
---------------------------------

I'm attaching a second diff, -instead- of the first diff.

This is because that although the RFC says its ok tho write host name without trailing slash,
there r some old servers and apps that doesn't know to parse URL without the trailing slash between the URL and the path/query part.
(look at: http://bugs.python.org/msg106649)

The second patch that i attached rewrites the slash when the TS is writing the " HTTP/1.1" text.
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.2.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "James Peach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Peach reassigned TS-1322:
-------------------------------

    Assignee: James Peach
    
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>            Assignee: James Peach
>             Fix For: 3.3.1
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "James Peach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Peach resolved TS-1322.
-----------------------------

    Resolution: Fixed

4dd567102f8ead628da636920e543ac270f6d229 TS-1322: CONNECT to parent proxy has URL with a trailing slash

                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>            Assignee: James Peach
>             Fix For: 3.3.1
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "James Peach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on TS-1322 started by James Peach.

> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>            Assignee: James Peach
>             Fix For: 3.3.1
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-1322:
------------------------------

    Fix Version/s:     (was: 3.2.0)
                   3.3.0
    
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.3.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yakov Kopel updated TS-1322:
----------------------------

    Attachment: TS.diff
    
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.2.0
>
>         Attachments: TS.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403021#comment-13403021 ] 

Yakov Kopel edited comment on TS-1322 at 6/28/12 11:41 AM:
-----------------------------------------------------------

I'm attaching a second patch, instead of the first patch.

This is because that although the RFC says its ok tho write host name without trailing slash,
there r some old servers and apps that doesn't know to parse URL without the trailing slash between the URL and the path/query part.
(look at: http://bugs.python.org/msg106649)

The second patch that i attached rewrites the slash when the TS is writing the " HTTP/1.1" text.
                
      was (Author: kopely):
    I'm attaching a second diff, -instead- of the first diff.

This is because that although the RFC says its ok tho write host name without trailing slash,
there r some old servers and apps that doesn't know to parse URL without the trailing slash between the URL and the path/query part.
(look at: http://bugs.python.org/msg106649)

The second patch that i attached rewrites the slash when the TS is writing the " HTTP/1.1" text.
                  
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.2.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415964#comment-13415964 ] 

Yakov Kopel commented on TS-1322:
---------------------------------

yes.
this is the definition of CONNECT request: HOST:PORT

as u can see in the RFC (http://www.ietf.org/rfc/rfc2817.txt) in paragraph 5.2:

 "the host name and port number destination of the requested connection separated by a colon"
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.3.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415936#comment-13415936 ] 

Yakov Kopel commented on TS-1322:
---------------------------------

yes.
The trailing slash is added in the URL.cc file in the url_print function:
  (line 1551) TRY(mime_mem_print("/", ....
This is done in all the calling of url_print.

The second patch that is done in the HTTP.cc file, remove that slash just after calling the url_print function:

         TRY(url_print(hdr->u.req.m_url_impl, buf, bufsize, bufindex, dumpoffset));
         if (bufsize - *bufindex >= 1) {
+          if (hdr->u.req.m_method_wks_idx == HTTP_WKSIDX_CONNECT) {
+              *bufindex -= 1; // remove trailing slash for CONNECT request
+          }
                
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.3.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TS-1322) CONNECT to parent proxy has URL with a trailing slash

Posted by "Yakov Kopel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yakov Kopel updated TS-1322:
----------------------------

    Attachment: second.diff
    
> CONNECT to parent proxy has URL with a trailing slash
> -----------------------------------------------------
>
>                 Key: TS-1322
>                 URL: https://issues.apache.org/jira/browse/TS-1322
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Yakov Kopel
>             Fix For: 3.2.0
>
>         Attachments: TS.diff, second.diff
>
>
> I want to redirect a CONNECT request to parent proxy.
> I'm doing it with the TSHttpTxnParentProxySet API.
> The problem is that the URL that the TS is setting is invalid:
> 	
> 	CONNECT www.example.com:443/ HTTP/1.1
> 	Host: www.example.com:443
> The TS adding to every URL a trailing slash in the end of the URL, but here it makes the URL invalid (look at http://www.ietf.org/rfc/rfc2817.txt  in section 5.2).
> Solution:
> 	I'm suggesting a patch for the URL.cc file that doesn't add a trailing slash when not needed (when there is only hostname).
> 	This is valid action as is written in the RFC (http://tools.ietf.org/html/rfc3986 in section 3) :
> 		"When authority is present, the path must either be empty -or- begin with a slash ("/") character"
> 	While" authority" is the hostaname.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira