You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/02/08 03:48:00 UTC
[GitHub] [kafka] ijuma opened a new pull request, #13218: MINOR: Remove unnecessary usage of `LazyIndex`
ijuma opened a new pull request, #13218:
URL: https://github.com/apache/kafka/pull/13218
The remote index classes use `LazyIndex`, but immediately force
materialization. This results in more verbose code and it's misleading
since the indexes are not lazily used in practice.
Also simplify `LazyIndex.forOffset/forTime` by removing `writable`
parameter, which is always `true`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd merged pull request #13218: MINOR: Remove unnecessary usage of `LazyIndex`
Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd merged PR #13218:
URL: https://github.com/apache/kafka/pull/13218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13218: MINOR: Remove unnecessary usage of `LazyIndex`
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13218:
URL: https://github.com/apache/kafka/pull/13218#issuecomment-1424207352
@satishd Thanks for the explanation. Can you show me where that happens? You can see that every change I made included a `.get.sanityCheck` call immediately after creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on pull request #13218: MINOR: Remove unnecessary usage of `LazyIndex`
Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd commented on PR #13218:
URL: https://github.com/apache/kafka/pull/13218#issuecomment-1427305151
> @satishd Thanks for the explanation. Can you show me where that happens? You can see that every place I replaced `LazyIndex`, there's a `.get.sanityCheck` call immediately after creation.
@ijuma You are right. Even while initializing there is a .getSanityCheck which does not really load it lazily. We can take a look at this later in how we can optimize the initialization path with LazyIndexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13218: MINOR: Remove unnecessary usage of `LazyIndex`
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13218:
URL: https://github.com/apache/kafka/pull/13218#issuecomment-1427082868
@satishd do you have additional comments regarding my question above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org