You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/11 05:31:07 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #68: Experimenting with arrow2

houqp commented on a change in pull request #68:
URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706565176



##########
File path: datafusion/src/scalar.rs
##########
@@ -64,7 +70,10 @@ pub enum ScalarValue {
     /// large binary
     LargeBinary(Option<Vec<u8>>),
     /// list of nested ScalarValue
-    List(Option<Vec<ScalarValue>>, DataType),
+    // 1st argument are the inner values (e.g. Int64Array)
+    // 2st argument is the Lists' datatype (i.e. it includes `Field`)
+    // to downcast inner values, use ListArray::<i32>::get_child()
+    List(Option<Arc<dyn Array>>, DataType),

Review comment:
       @jorgecarleitao do you remember what's reason for changing from vector of ScalarValue to Arrow array here? Is it for static typing of the individual list values?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org