You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2025/09/30 17:24:25 UTC

[PR] feat: Add Operator Registry [opendal]

Xuanwo opened a new pull request, #6608:
URL: https://github.com/apache/opendal/pull/6608

   # Which issue does this PR close?
   
   Part of https://github.com/apache/opendal/issues/5445
   
   # Rationale for this change
   
   This PR will allow users to load operator from uri.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add Operator Registry [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #6608:
URL: https://github.com/apache/opendal/pull/6608#issuecomment-3355244176

   @Xuanwo I can see that users still need to pass `options` to populate concrete opts, like for S3, I currently configure:
   
   ```
   type = "s3"
   bucket = "test-bucket"
   region = "us-east-1"
   root = "/"
   endpoint = "..."
   access_key_id = "..."
   secret_access_key = "..."
   virtual_host_style = false
   ```
   
   Seems the current registry supports only:
   
   ```
   let op = Operator::from_uri("s3://test-bucket/", [])?;
   ```
   
   Then what about other fields?
   
   Especially, how the `endpoint` should be configured.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add Operator Registry [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6608:
URL: https://github.com/apache/opendal/pull/6608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add Operator Registry [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6608:
URL: https://github.com/apache/opendal/pull/6608#issuecomment-3355449577

   > I don't see the code to read options from URI options.
   
   Working on a refactor, should be supported in the next PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add Operator Registry [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6608:
URL: https://github.com/apache/opendal/pull/6608#issuecomment-3355325844

   > Seems the current registry supports only:
   
   People can pass by either in uri or in options:
   
   ```
   let op = Operator::from_uri("s3://test-bucket?region=\"us-east-1\"", [("virtual_host_style", "false")])?;
   ```
   
   For `endpoint`, it currently supports:
   
   ```
   let endpoint = "https://xxxx.minio.local";
   let op = Operator::from_uri("s3://test-bucket", [("endpoint", endpoint)])?;
   ```
   
   But I think it can be extended to:
   
   ```
   let op = Operator::from_uri("s3://xxxx.minio.local/test-bucket", [])?;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add Operator Registry [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #6608:
URL: https://github.com/apache/opendal/pull/6608#issuecomment-3355409558

   ```
   let op = Operator::from_uri("s3://test-bucket?region=\"us-east-1\"", [("virtual_host_style", "false")])?;
   ```
   
   I don't see the code to read options from URI options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org