[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #10455: chore: Migrate Timer component from jsx to tsx

[GitBox <gi...@apache.org>]

mistercrunch edited a comment on pull request #10455:
URL: https://github.com/apache/incubator-superset/pull/10455#issuecomment-670326100


   @etr2460 when using a simple `mv` (or renaming in an IDE for instance), the `jsx` file will show as deleted and the `tsx` file as new. When using `git mv`, the history of the file stays attached to it.
   
   This is my similar PR that keeps the history: https://github.com/apache/incubator-superset/pull/10529/files
   
   Not a huge deal, but generally it's better to keep the history. I do more git archeology than I should (trying to figure out how a certain line of code or section came to be) and I'll run `git blame`, sometimes multiple times through layers of edits, or look at Github's history pages for a given file, and it's nice to keep history attached when possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org