You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/01 16:00:17 UTC
[jira] [Commented] (TINKERPOP3-1012) BulkLoaderVertexProgram
shouldn't assume vertex IDs of type Long
[ https://issues.apache.org/jira/browse/TINKERPOP3-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033822#comment-15033822 ]
ASF GitHub Bot commented on TINKERPOP3-1012:
--------------------------------------------
GitHub user dalaro opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/163
TINKERPOP3-1012 generalize BLVP vertex id types
Change the type of two vertex ID variable declarations from Long to Object. As mentioned in the JIRA, his should be reviewed. I'm not sure this is the right change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dalaro/incubator-tinkerpop TINKERPOP3-1012
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit e2fb9b4c24a02289f629d4dd69d01a9a40ab4233
Author: Dan LaRocque <da...@hopcount.org>
Date: 2015-12-01T13:29:22Z
TINKERPOP3-1012 generalize BLVP vertex id types
Change the type of two vertex ID variable declarations from Long to
Object. Supports graphs that don't use Long vertex IDs or
user-supplied IDs.
----
> BulkLoaderVertexProgram shouldn't assume vertex IDs of type Long
> ----------------------------------------------------------------
>
> Key: TINKERPOP3-1012
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-1012
> Project: TinkerPop 3
> Issue Type: Bug
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Dan LaRocque
> Assignee: Daniel Kuppitz
> Fix For: 3.1.1-incubating
>
>
> BulkLoaderVertexProgram has two lines where it declares a vertex ID variable of type Long. While testing bulk loading into a TP impl that uses non-Long object IDs with {{userSuppliedIds(false)}}, I found that I needed to change the variable type declaration on both of these lines to Object to avoid cast exceptions that otherwise killed BLVP. However, I am *not* certain that these changes are correct. It's also possible that I just misconfigured BLVP. So, I'll submit a PR with the declarations that I changed, but it would definitely need to be reviewed by somebody familiar with BLVP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)