[jira] [Commented] (DL-184) The default graceful shutdown config value is greater than timeout in script's

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DL-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817630#comment-15817630 ] 

ASF GitHub Bot commented on DL-184:
-----------------------------------

GitHub user xieliang opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/115

    DL-184 : reduce server_graceful_shutdown_period_ms from 35s to 20s, which is smaller than the default daemon stop timeout value

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xieliang/incubator-distributedlog DL-184-graceful

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----

----


> The default graceful shutdown config value is greater than timeout in script's
> ------------------------------------------------------------------------------
>
>                 Key: DL-184
>                 URL: https://issues.apache.org/jira/browse/DL-184
>             Project: DistributedLog
>          Issue Type: Improvement
>          Components: distributedlog-service
>    Affects Versions: 0.4.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>
> In conf/write_proxy.conf :
> server_graceful_shutdown_period_ms=35000
> In bin/dlog-daemon.sh :
> DLOG_STOP_TIMEOUT=${DLOG_STOP_TIMEOUT:-30}
> so by default, every stop server request will be finished with an ungraceful shutdown behavior.
> should we change the default server_graceful_shutdown_period_ms to a smaller one , i.e. 20000 ?   any suggestions are welcomed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)