You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 03:22:10 UTC
[jira] [Created] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Add support for Phabricator/Differential as an alternative code review tool
---------------------------------------------------------------------------
Key: HBASE-4611
URL: https://issues.apache.org/jira/browse/HBASE-4611
Project: HBase
Issue Type: Task
Reporter: Jonathan Gray
>From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141547#comment-13141547 ]
Phabricator commented on HBASE-4611:
------------------------------------
nspiegelberg has committed the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D153
COMMIT
https://reviews.facebook.net/rHBASE1196257
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141592#comment-13141592 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D207
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141590#comment-13141590 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D165
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg resolved HBASE-4611.
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
0.92.0
we had the entire FB HBase team go through the steps I mentioned for using arc today. They were able to successfully install arc and use it to create an example diff (hence all the activity on this diff today). Any interested parties, please give it a whirl and give feedback.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D153.1.patch
nspiegelberg requested code review of "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: stack, JIRA
Add maven task to setup an arc client & provide a good initial
default configuration.
TEST PLAN
- mvn initialize -Darc
REVISION DETAIL
https://reviews.facebook.net/D153
AFFECTED FILES
.arcconfig
.gitignore
pom.xml
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4611:
---------------------------------------
Comment: was deleted
(was: nspiegelberg requested code review of "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: DUMMY_REVIEWER
Adding more awesome
From <a href="http://phabricator.org/">http://phabricator.org/</a> : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at <a href="http://reviews.facebook.net">http://reviews.facebook.net</a> (sponsored by Facebook and hosted by the OSUOSL <a href="http://osuosl.org">http://osuosl.org</a>).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
http://reviews.facebook.net/D21
AFFECTED FILES
CHANGES.txt
MANAGE HERALD DIFFERENTIAL RULES
http://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
http://reviews.facebook.net/herald/transcript/51/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141752#comment-13141752 ]
Hudson commented on HBASE-4611:
-------------------------------
Integrated in HBase-TRUNK #2397 (See [https://builds.apache.org/job/HBase-TRUNK/2397/])
Fixed CHANGES file for HBASE-4532 & HBASE-4611
HBASE-4611 Add support for Phabricator/Differential as an alternative code review tool
nspiegelberg :
Files :
* /hbase/trunk/CHANGES.txt
nspiegelberg :
Files :
* /hbase/trunk/.arcconfig
* /hbase/trunk/.gitignore
* /hbase/trunk/pom.xml
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140931#comment-13140931 ]
Phabricator commented on HBASE-4611:
------------------------------------
nspiegelberg has abandoned the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D21
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D177.1.patch
jgray requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
Whoo
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D177
AFFECTED FILES
CHANGES.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/351/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140548#comment-13140548 ]
John Sichi commented on HBASE-4611:
-----------------------------------
Marek has just checked in support for svn workflows as well.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133513#comment-13133513 ]
John Sichi commented on HBASE-4611:
-----------------------------------
@Liyin: yeah, for now we haven't thought of a good solution for the ASF grant yet. I'm not sure but I'm guessing it would need to be done explicitly through the Jira UI to be valid. So for now, it's necessary for the contributor to reattach the final patch manually (and grant then) before the committer commits it.
Any suggestions on this one?
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141584#comment-13141584 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D171
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141588#comment-13141588 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D177
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140932#comment-13140932 ]
Phabricator commented on HBASE-4611:
------------------------------------
nspiegelberg has abandoned the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D21
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Liyin Tang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130137#comment-13130137 ]
Liyin Tang commented on HBASE-4611:
-----------------------------------
Very Awesome. I have tried to created one review on Phabricator :)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D171.1.patch
mareksapotafb requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
abc
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D171
AFFECTED FILES
README.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/345/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4611:
---------------------------------------
Comment: was deleted
(was: nspiegelberg requested code review of "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: DUMMY_REVIEWER
Adding more awesome
From <a href="http://phabricator.org/">http://phabricator.org/</a> : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at <a href="http://reviews.facebook.net">http://reviews.facebook.net</a> (sponsored by Facebook and hosted by the OSUOSL <a href="http://osuosl.org">http://osuosl.org</a>).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
http://reviews.facebook.net/D21
AFFECTED FILES
CHANGES.txt
MANAGE HERALD DIFFERENTIAL RULES
http://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
http://reviews.facebook.net/herald/transcript/51/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141564#comment-13141564 ]
Phabricator commented on HBASE-4611:
------------------------------------
Karthik has commented on the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
INLINE COMMENTS
README.txt:31 Need a "9. " here :)
REVISION DETAIL
https://reviews.facebook.net/D189
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: HBASE-4611.D423.1.patch
nspiegelberg requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
this is a test
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D423
AFFECTED FILES
bin/hbase
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/843/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141591#comment-13141591 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D183
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141865#comment-13141865 ]
Hudson commented on HBASE-4611:
-------------------------------
Integrated in HBase-0.92 #96 (See [https://builds.apache.org/job/HBase-0.92/96/])
HBASE-4611 Add support for Phabricator/Differential as an alternative code review tool
nspiegelberg :
Files :
* /hbase/branches/0.92/.arcconfig
* /hbase/branches/0.92/.gitignore
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/pom.xml
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151485#comment-13151485 ]
Nicolas Spiegelberg commented on HBASE-4611:
--------------------------------------------
@stack: note that the certificate installation is not a long process. It just has you visit a webpage while logged into FB & give a displayed ID. Although annonymous access for contributors should be fine, I'd recommend secure access for all committers since they'll be approving diffs for inclusion.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D201.1.patch
pritamdamania requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
1) Changed README.txt
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D201
AFFECTED FILES
README.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/387/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4611:
---------------------------------------
Comment: was deleted
(was: stack has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
I thing this change is really awesome
REVISION DETAIL
https://reviews.facebook.net/D21
)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: HBASE-4611.D423.2.patch
nspiegelberg updated the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
changed to test2
REVISION DETAIL
https://reviews.facebook.net/D423
AFFECTED FILES
bin/hbase
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139464#comment-13139464 ]
stack commented on HBASE-4611:
------------------------------
Whats left on this? A few of us are starting to use this tool. Do we need to port some of John's Hive doc to our manual or at least pointers?
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D165.1.patch
Karthik requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
Test change
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D165
AFFECTED FILES
README.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/339/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D207.1.patch
aaiyer requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
test diff to see the arc submission process.
not intended to be committed
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D207
AFFECTED FILES
pom.xml
README.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/393/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141589#comment-13141589 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D201
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D165.2.patch
Karthik updated the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA, madhuvaidya, Kannan
Testing updating the diff
REVISION DETAIL
https://reviews.facebook.net/D165
AFFECTED FILES
README.txt
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D189.1.patch
madhuvaidya requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
Test.
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D189
AFFECTED FILES
README.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/369/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Marek Sapota (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130153#comment-13130153 ]
Marek Sapota commented on HBASE-4611:
-------------------------------------
I believe accounts need a valid email address so either way we would need some help - I'll create an INFRA task.
JIRA saves descriptions as HTML, hopefully some simple replacements will be enough to convert them to plain text.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141411#comment-13141411 ]
Phabricator commented on HBASE-4611:
------------------------------------
nspiegelberg has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
INLINE COMMENTS
.arcconfig:11 I was just copy-pasting a config example you had. I'll remove this.
REVISION DETAIL
https://reviews.facebook.net/D153
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130140#comment-13130140 ]
Jonathan Gray commented on HBASE-4611:
--------------------------------------
Looks like you're one step ahead on the <a> tags, thanks!
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132190#comment-13132190 ]
John Sichi commented on HBASE-4611:
-----------------------------------
Hey HBase peeps (this is the real me writing, I swear):
Besides committing the project-specific .arcconfig file, we're also going to need to make available the arcanist extensions Marek has developed. Most of this will be the same across Hive/HBase/HCatalog/etc (although each project might have its own additional extensions for stuff like linting rules).
We could just commit these redundantly to each project, but that would make maintaining them a pain.
Alternatively, we can maintain the common extensions somewhere independently (e.g. github or apache extras), and have each project pull it in via a build command. For example, in Hive I might run "ant arc-install" in a new sandbox to get it; HBase would supply a mvn command.
Thoughts?
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg reassigned HBASE-4611:
------------------------------------------
Assignee: Nicolas Spiegelberg
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130139#comment-13130139 ]
Jonathan Gray commented on HBASE-4611:
--------------------------------------
@Marek, we could file an INFRA task. Or we could create a new account? Also, there seems to be something with URL translation (JIRA is treating the <a> tag as escaped so actually showing it, and then converting straight text URLs to hyperlinks).
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4611:
---------------------------------------
Comment: was deleted
(was: stack has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
I thing this change is really awesome
REVISION DETAIL
https://reviews.facebook.net/D21
)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "jsichi (John Sichi) (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
jsichi (John Sichi) updated HBASE-4611:
---------------------------------------
Attachment: D21.1.patch
nspiegelberg requested code review of "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: DUMMY_REVIEWER
Adding more awesome
From <a href="http://phabricator.org/">http://phabricator.org/</a> : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at <a href="http://reviews.facebook.net">http://reviews.facebook.net</a> (sponsored by Facebook and hosted by the OSUOSL <a href="http://osuosl.org">http://osuosl.org</a>).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
http://reviews.facebook.net/D21
AFFECTED FILES
CHANGES.txt
MANAGE HERALD DIFFERENTIAL RULES
http://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
http://reviews.facebook.net/herald/transcript/51/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150986#comment-13150986 ]
stack commented on HBASE-4611:
------------------------------
Do I need a cert to talk to phabricator?
{code}
h-25-20:arcanist stack$ ./bin/arc patch D459
Usage Exception: YOU NEED TO INSTALL A CERTIFICATE TO LOGIN TO PHABRICATOR
You are trying to connect to 'https://secure.phabricator.com/api/' but do not have a certificate installed for this host. Run:
$ arc install-certificate
...to install one.
{code}
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Marek Sapota (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130128#comment-13130128 ]
Marek Sapota commented on HBASE-4611:
-------------------------------------
We probably should=) Do you know who might be able to do that? Since the account was auto-created with a phony email we would need an administrator help to access it.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Marek Sapota (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151496#comment-13151496 ]
Marek Sapota commented on HBASE-4611:
-------------------------------------
Anonymous access only allows you read-only actions like browsing the revisions or getting a patch from Differential. Contributors will still need to log in to run `arc diff` or comment on revisions. Also I would call it authenticated access (Phabricator knows who you are, which allows you to upload diffs, etc. as you without manually authenticating every time you run `arc diff`), not secure access to avoid confusion - installing the certificate won't make you more secure and using the anonymous access won't make you more prone to attacks. Both access methods are protected by HTTPS, so Arcanist will talk only to the real reviews.facebook.net and the communication is encrypted.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Liyin Tang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133202#comment-13133202 ]
Liyin Tang commented on HBASE-4611:
-----------------------------------
One problem I just found is the patch automatically attached by phabricator does not have the ASF license. Also this patch cannot be deleted.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137418#comment-13137418 ]
Phabricator commented on HBASE-4611:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
I thing this change is really awesome
REVISION DETAIL
https://reviews.facebook.net/D21
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Marek Sapota (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150998#comment-13150998 ]
Marek Sapota commented on HBASE-4611:
-------------------------------------
secure.phabricator.com doesn't allow anonymous access, reviews.facebook.net that we use has anonymous access enabled. Keep in mind that this is a new feature and not everything is "anonymous aware". `arc patch` will work with an updated Arcanist, if you need any other particular workflow to work without a certificate and it doesn't right now, drop me an email, I can probably fix it.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg closed HBASE-4611.
--------------------------------------
Fixed. Please see HBASE-4896 to make sure we add proper documentation.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129397#comment-13129397 ]
Jonathan Gray commented on HBASE-4611:
--------------------------------------
In addition to being a (better) code review tool, the Phabricator suite also includes stuff like repo/revision browsing, nice command-line tools, pastebin, etc. which should be available for the HBase repos.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130121#comment-13130121 ]
Jonathan Gray commented on HBASE-4611:
--------------------------------------
Should we change the display name of the reviews.facebook.net account from John Sichi? :)
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151346#comment-13151346 ]
stack commented on HBASE-4611:
------------------------------
Thank you Marek. Let me try again later today...
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D207.1.patch, D21.1.patch, D21.1.patch, HBASE-4611.D423.1.patch, HBASE-4611.D423.2.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141394#comment-13141394 ]
Phabricator commented on HBASE-4611:
------------------------------------
mareksapotafb has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
INLINE COMMENTS
.arcconfig:11 Do you really need that there? That just would complain about errors in Arc-JIRA code when you really want to lint HBase code.
REVISION DETAIL
https://reviews.facebook.net/D153
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140930#comment-13140930 ]
Nicolas Spiegelberg commented on HBASE-4611:
--------------------------------------------
After we checkin D153, we need to make a help wiki similar to Hive's
https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
The main difference is that 'ant arc-setup' becomes 'mvn initialize -Darc'. Note that arc is not a required tool. You can create a diff by uploading a raw diff file ( https://reviews.facebook.net/differential/diff/create/ ). 'arc' is just a command line tool that we use to get stuff done faster. Currently, only 'arc diff' will show you the context around your diff, which is super-nice. Working with Marek to get feature parity here on patch upload.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137417#comment-13137417 ]
Phabricator commented on HBASE-4611:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
I thing this change is really awesome
REVISION DETAIL
https://reviews.facebook.net/D21
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141559#comment-13141559 ]
Phabricator commented on HBASE-4611:
------------------------------------
madhuvaidya has abandoned the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
:)
REVISION DETAIL
https://reviews.facebook.net/D189
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D201.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141556#comment-13141556 ]
Phabricator commented on HBASE-4611:
------------------------------------
Karthik has accepted the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
REVISION DETAIL
https://reviews.facebook.net/D189
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D165.2.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D189.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D183.1.patch
jgray requested code review of "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
It's open source so pretty much anyone could host an instance of this software.
To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D183
AFFECTED FILES
CHANGES.txt
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/363/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Marek Sapota (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140936#comment-13140936 ]
Marek Sapota commented on HBASE-4611:
-------------------------------------
It is possible to get context with the web interface, just upload a diff file generated with all the context that you need (for example `git diff -U 9999`. This is exactly what Arcanist does for you with `arc diff`.
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4611:
-------------------------------
Attachment: D177.2.patch
jgray updated the revision "HBASE-4611 [jira] Add support for Phabricator/Differential as an alternative code review tool".
Reviewers: JIRA
REVISION DETAIL
https://reviews.facebook.net/D177
AFFECTED FILES
CHANGES.txt
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D165.1.patch, D171.1.patch, D177.1.patch, D177.2.patch, D183.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137343#comment-13137343 ]
John Sichi commented on HBASE-4611:
-----------------------------------
We've published the JIRA integration module on github:
https://github.com/facebook/arc-jira
Here's how we made it installable from Hive:
https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
https://issues.apache.org/jira/secure/attachment/12500986/D51.2.patch
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Attachments: D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4611) Add support for
Phabricator/Differential as an alternative code review tool
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141534#comment-13141534 ]
Phabricator commented on HBASE-4611:
------------------------------------
jgray has accepted the revision "[jira] [HBASE-4611] Add support for Phabricator/Differential as an alternative code review tool".
lgtm
REVISION DETAIL
https://reviews.facebook.net/D153
> Add support for Phabricator/Differential as an alternative code review tool
> ---------------------------------------------------------------------------
>
> Key: HBASE-4611
> URL: https://issues.apache.org/jira/browse/HBASE-4611
> Project: HBase
> Issue Type: Task
> Reporter: Jonathan Gray
> Assignee: Nicolas Spiegelberg
> Attachments: D153.1.patch, D21.1.patch, D21.1.patch
>
>
> From http://phabricator.org/ : "Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. It is currently available as an early release. Phabricator was developed at Facebook."
> It's open source so pretty much anyone could host an instance of this software.
> To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org).
> We will use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira