You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/10/08 11:57:46 UTC

[GitHub] [accumulo] milleruntime commented on pull request #2297: Rework GC rest code in Monitor

milleruntime commented on pull request #2297:
URL: https://github.com/apache/accumulo/pull/2297#issuecomment-938583660


   @ctubbsii I was thinking more about our comments and was wondering what you think of renaming the classes in the Monitor that get turned into JSON?  I noticed that we have a lot of classes in the monitor with generic names, like `Compactions` and `Scans`. These classes contain the variable names for the JSON and if we change will break the front end code. It doesn't make sense to call them `Impl` as we do in other places. What do you think about renaming these classes to something like `CompactionsJSON` or `ScansJSON` to help differentiate it from other back-end classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org