You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Munendra S N (Jira)" <ji...@apache.org> on 2020/03/06 12:54:00 UTC
[jira] [Commented] (SOLR-13944) CollapsingQParserPlugin throws NPE
instead of bad request
[ https://issues.apache.org/jira/browse/SOLR-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053385#comment-17053385 ]
Munendra S N commented on SOLR-13944:
-------------------------------------
[^SOLR-13944.patch]
Initial patch for fixing NPE.
This is valid, as defType for fq is by default is lucene and then localParams syntax is parsed but the case of tagging for collapse filter wasn't handled in SOLR-8807 (it was doing a simple string match). Here, I have replaced it with filter parsing, without that we can't know if there is collapse filter or not.
{noformat}
fq={!tag=collapser}{!collapse field=productId sort='merchantOrder asc, price asc, id asc'}
{noformat}
[~tflobbe] As you had asked the user to create the JIRA issue, I would prefer if you could take look at this patch
> CollapsingQParserPlugin throws NPE instead of bad request
> ---------------------------------------------------------
>
> Key: SOLR-13944
> URL: https://issues.apache.org/jira/browse/SOLR-13944
> Project: Solr
> Issue Type: Bug
> Affects Versions: 7.3.1
> Reporter: Stefan
> Assignee: Munendra S N
> Priority: Minor
> Attachments: SOLR-13944.patch
>
>
> I noticed the following NPE:
> {code:java}
> java.lang.NullPointerException at org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1021) at org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1081) at org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:230) at org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1602) at org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1419) at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:584)
> {code}
> If I am correct, the problem was already addressed in SOLR-8807. The fix does was not working in this case though, because of a syntax error in the query (I used the local parameter syntax twice instead of combining it). The relevant part of the query is:
> {code:java}
> &fq={!tag=collapser}{!collapse field=productId sort='merchantOrder asc, price asc, id asc'}
> {code}
> After discussing that on the mailing list, I was asked to open a ticket, because this situation should result in a bad request instead of a NullpointerException (see [https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201911.mbox/%3CCAMJgJxTuSb%3D8szO8bvHiAafJOs08O_NMB4pcaHOXME4Jj-GO2A%40mail.gmail.com%3E])
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org