You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:56:30 UTC

[GitHub] [arrow-ballista] onthebridgetonowhere commented on a diff in pull request #309: [UI] Use tabbed pane with Queries and Executors tabs

onthebridgetonowhere commented on code in PR #309:
URL: https://github.com/apache/arrow-ballista/pull/309#discussion_r985284011


##########
ballista/ui/scheduler/src/App.tsx:
##########
@@ -50,20 +60,43 @@ const App: React.FunctionComponent<any> = () => {
       .then((res) => setJobs(res));
   }
 
+  function getExecutors() {
+    return fetch(`/api/executors`, {
+      method: "POST",
+      headers: {
+        Accept: "application/json",
+      },
+    })
+      .then((res) => res.json())
+      .then((res) => setExecutors(res));
+  }
+
   useEffect(() => {
     getSchedulerState();
     getJobs();
+    getExecutors();
   }, []);
 
-  console.log(JSON.stringify(schedulerState));
-
   return (
     <Box>
       <Grid minH="100vh">
         <VStack alignItems={"flex-start"} spacing={0} width={"100%"}>
           <Header schedulerState={schedulerState} />
           <Summary schedulerState={schedulerState} />
-          <QueriesList queries={jobs} />
+          <Tabs>

Review Comment:
   We probably want to have here: `<Tabs width={"100%"}>`



##########
ballista/ui/scheduler/src/components/ExecutorsList.tsx:
##########
@@ -56,16 +61,12 @@ const columns: Column<any>[] = [
   },
 ];
 
-interface NodesListProps {
-  nodes: NodeInfo[];
-}
-
-export const NodesList: React.FunctionComponent<NodesListProps> = ({
-  nodes = [],
+export const ExecutorsList: React.FunctionComponent<ExecutorsListProps> = ({
+  executors = [],
 }) => {
   return (
     <Box flex={1}>
-      <DataTable maxW={960} columns={columns} data={nodes} pageSize={4} />
+      <DataTable maxW={960} columns={columns} data={executors} pageSize={4} />

Review Comment:
   The `maxW` property is not really useful, unless we need this width size restriction. Removing it makes the table look better. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org