You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/22 06:18:01 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #13571: [chore](macOS) Fix the issues with protoc and protoc-gen-grpc-java on M1
adonis0147 opened a new pull request, #13571:
URL: https://github.com/apache/doris/pull/13571
# Proposed changes
~~Issue Number: close #xxx~~
## Problem summary
There are some errors occur when building FE by JDK (arm64) on M1 because the dependencies `protoc` and `grpc-java` doesn't support M1. #13563 modified the `build.sh` to fix this issues by adding `-Dos.arch=x86_64` to build command. However, if some one executes `mvn clean package -DskipTests=true` under the folder `fe`, the errors will occur again.
This PR introduces a better way to fix them.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13571: [chore](macOS) Fix the issues with protoc and protoc-gen-grpc-java on M1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13571:
URL: https://github.com/apache/doris/pull/13571#issuecomment-1287834500
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13571: [chore](macOS) Fix the issues with protoc and protoc-gen-grpc-java on M1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13571:
URL: https://github.com/apache/doris/pull/13571#issuecomment-1287834477
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13571: [chore](macOS) Fix the issues with protoc and protoc-gen-grpc-java on M1
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13571:
URL: https://github.com/apache/doris/pull/13571#issuecomment-1287755960
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.53 seconds
load time: 551 seconds
storage size: 17154887257 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221022103338_clickbench_pr_32738.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #13571: [chore](macOS) Fix the issues with protoc and protoc-gen-grpc-java on M1
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #13571:
URL: https://github.com/apache/doris/pull/13571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org