You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 18:10:40 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request #333: Fix comparison of dictionaries with different values arrays (#332)

tustvold opened a new pull request #333:
URL: https://github.com/apache/arrow-rs/pull/333


   # Which issue does this PR close?
   
   Closes #332.
   
    # Rationale for this change
   
   Currently when comparing dictionaries it will use the values array from the left operand with the keys of the right operand. Not only could this lead to invalid indexes, but it will commonly lead to incorrect results
   
   # Are there any user-facing changes?
   
   Comparison should now behave as the user would expect
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #333: Fix comparison of dictionaries with different values arrays (#332)

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #333:
URL: https://github.com/apache/arrow-rs/pull/333#discussion_r636413738



##########
File path: arrow/src/array/ord.rs
##########
@@ -94,7 +94,7 @@ where
     let right_keys = right.keys_array();
 
     let left_values = StringArray::from(left.values().data().clone());
-    let right_values = StringArray::from(left.values().data().clone());
+    let right_values = StringArray::from(right.values().data().clone());

Review comment:
       ![image](https://user-images.githubusercontent.com/490673/119038562-438a7800-b981-11eb-8949-d1fe5659d314.png)
   
   🤦 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #333: Fix comparison of dictionaries with different values arrays (#332)

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #333:
URL: https://github.com/apache/arrow-rs/pull/333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a change in pull request #333: Fix comparison of dictionaries with different values arrays (#332)

Posted by GitBox <gi...@apache.org>.
tustvold commented on a change in pull request #333:
URL: https://github.com/apache/arrow-rs/pull/333#discussion_r636342599



##########
File path: arrow/src/array/ord.rs
##########
@@ -94,7 +94,7 @@ where
     let right_keys = right.keys_array();
 
     let left_values = StringArray::from(left.values().data().clone());
-    let right_values = StringArray::from(left.values().data().clone());
+    let right_values = StringArray::from(right.values().data().clone());

Review comment:
       Here's the copypasta




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org