You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Matt Cooper (JIRA)" <ad...@incubator.apache.org> on 2006/09/25 20:38:50 UTC
[jira] Created: (ADFFACES-197) Semantic group component, its DOM,
its children
Semantic group component, its DOM, its children
-----------------------------------------------
Key: ADFFACES-197
URL: http://issues.apache.org/jira/browse/ADFFACES-197
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Matt Cooper
Priority: Minor
Attachments: trinidad.patch
Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (ADFFACES-197) Semantic group component, its DOM, its children
Posted by Matt Cooper <ma...@gmail.com>.
Thank you Adam and Matthias
On 9/25/06, Adam Winer (JIRA) <ad...@incubator.apache.org> wrote:
>
> [ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
>
> Adam Winer updated ADFFACES-197:
> --------------------------------
>
> Status: Resolved (was: Patch Available)
> Resolution: Fixed
>
> Checked in. BTW, for patches that include deleted files, I don't think
> that can go in the patch - you really have to issue an "svn remove" from the
> command line.
>
> > Semantic group component, its DOM, its children
> > -----------------------------------------------
> >
> > Key: ADFFACES-197
> > URL: http://issues.apache.org/jira/browse/ADFFACES-197
> > Project: MyFaces ADF-Faces
> > Issue Type: Improvement
> > Reporter: Matt Cooper
> > Priority: Minor
> > Attachments: trinidad.patch
> >
> >
> > Update the CoreGroupRenderer so that it renders zero DOM for itself
> since it is a semantic wrapper. Currently it renders a span element and an
> ID attribute--it should render nothing except for its children in their raw
> HTML form. This component is not a layout component so there should be no
> DIVs, TDs, or SPANs around its children.
> > A patch will be added that cleans all of this up. It has no side
> effects for parents that treat groups specially, e.g. the
> panelFormLayout. Note that the patch removes renderkit tests (the golden
> file tests) because this component has no visual representation. It also
> happens to break the unit test implementation of the ResponseWriter in its
> startElement because it will get confused with the component tree since the
> group renders no elements for itself. The particular stack trace is:
> > junit.framework.AssertionFailedError: The wrong UIComponent was passed
> to startElement("span",...)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement
> (GatherContent.java:110)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin
> (OutputTextRenderer.java:58)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin
> (CoreRenderer.java:159)
> > at
> org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(
> UIXComponentBase.java:640)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild
> (CoreRenderer.java:244)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren
> (CoreRenderer.java:277)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll
> (GroupRenderer.java:67)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(
> CoreRenderer.java:181)
> > at
> org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(
> UIXComponentBase.java:673)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(
> RenderUtils.java:66)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(
> RenderUtils.java:61)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild
> (CoreRenderer.java:255)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren
> (CoreRenderer.java:277)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent
> (PanelPartialRootRenderer.java:70)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent
> (BodyRenderer.java:134)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll
> (PanelPartialRootRenderer.java:150)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll
> (BodyRenderer.java:76)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer
> (CoreRenderer.java:294)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll
> (DocumentRenderer.java:78)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(
> CoreRenderer.java:181)
> > at
> org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(
> UIXComponentBase.java:673)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(
> RenderUtils.java:66)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(
> RenderUtils.java:61)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot
> (RenderKitTestCase.java:177)
> > at
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest
> (RenderKitTestCase.java:323)
> > at junit.framework.TestCase.runBare(TestCase.java:127)
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Matt Cooper (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
Matt Cooper updated ADFFACES-197:
---------------------------------
Attachment: (was: trinidad.patch)
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: http://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matt Cooper
> Priority: Minor
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Matt Cooper (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
Matt Cooper updated ADFFACES-197:
---------------------------------
Attachment: trinidad.patch
All the updates to support the required behavior but also since there is no visual representation, it didn't make sense to have a customizable renderer... now, there is a UIXGroupTemplate for the UIXGroup component that does the rendering of the children automatically. CoreGroup has been deleted.
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: http://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matt Cooper
> Priority: Minor
> Attachments: trinidad.patch
>
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Matt Cooper (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
Matt Cooper updated ADFFACES-197:
---------------------------------
Attachment: trinidad.patch
Updated component documentation, improved demo, fixed renderer, removed golden renderkit tests.
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: http://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matt Cooper
> Priority: Minor
> Attachments: trinidad.patch
>
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
Adam Winer updated ADFFACES-197:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Checked in. BTW, for patches that include deleted files, I don't think that can go in the patch - you really have to issue an "svn remove" from the command line.
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: http://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matt Cooper
> Priority: Minor
> Attachments: trinidad.patch
>
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Matt Cooper (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-197?page=all ]
Matt Cooper updated ADFFACES-197:
---------------------------------
Status: Patch Available (was: Open)
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: http://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matt Cooper
> Priority: Minor
> Attachments: trinidad.patch
>
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-197) Semantic group component, its DOM,
its children
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-197:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Semantic group component, its DOM, its children
> -----------------------------------------------
>
> Key: ADFFACES-197
> URL: https://issues.apache.org/jira/browse/ADFFACES-197
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Matt Cooper
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: trinidad.patch
>
>
> Update the CoreGroupRenderer so that it renders zero DOM for itself since it is a semantic wrapper. Currently it renders a span element and an ID attribute--it should render nothing except for its children in their raw HTML form. This component is not a layout component so there should be no DIVs, TDs, or SPANs around its children.
> A patch will be added that cleans all of this up. It has no side effects for parents that treat groups specially, e.g. the panelFormLayout. Note that the patch removes renderkit tests (the golden file tests) because this component has no visual representation. It also happens to break the unit test implementation of the ResponseWriter in its startElement because it will get confused with the component tree since the group renders no elements for itself. The particular stack trace is:
> junit.framework.AssertionFailedError: The wrong UIComponent was passed to startElement("span",...)
> at org.apache.myfaces.trinidadinternal.renderkit.GatherContent$CheckUIComponent.startElement(GatherContent.java:110)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextRenderer.encodeBegin(OutputTextRenderer.java:58)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeBegin(CoreRenderer.java:159)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegin(UIXComponentBase.java:640)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:244)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.GroupRenderer.encodeAll(GroupRenderer.java:67)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeChild(CoreRenderer.java:255)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeAllChildren(CoreRenderer.java:277)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.renderContent(PanelPartialRootRenderer.java:70)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.renderContent(BodyRenderer.java:134)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:150)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:76)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.delegateRenderer(CoreRenderer.java:294)
> at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:78)
> at org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer.encodeEnd(CoreRenderer.java:181)
> at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:673)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:66)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderUtils.encodeRecursive(RenderUtils.java:61)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseTest.renderRoot(RenderKitTestCase.java:177)
> at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$RendererTest.runTest(RenderKitTestCase.java:323)
> at junit.framework.TestCase.runBare(TestCase.java:127)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.