You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Lutz Tietze (JIRA)" <ji...@apache.org> on 2008/08/17 14:03:44 UTC
[jira] Created: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
German umlauts not displayed properly on OC4J installation
----------------------------------------------------------
Key: JSPWIKI-348
URL: https://issues.apache.org/jira/browse/JSPWIKI-348
Project: JSPWiki
Issue Type: Bug
Components: Servlet Container/Java compatibility
Affects Versions: 2.6.3, 2.6.2, 2.6.1, 2.6.0
Environment: openSuSe 10.3/Windows XP
Oracle Container for J2EE (OC4J 10.1.3.1)
JSPWiki 2.6.0/2.6.3
Firefox 3/IE 6
Reporter: Lutz Tietze
Fix For: 2.6.3
The German umlauts are shown as chinese (?) letters.
The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627724#action_12627724 ]
Lutz Tietze commented on JSPWIKI-348:
-------------------------------------
The original class is {{org.ofbiz.base.util.UtilJ2eeCompat.java}} in the [Apache Open for Business Project|http://ofbiz.apache.org/]. The license is exactly the same as in your project. You can get the current files from the [SVN Repository|http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/].
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624823#action_12624823 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
The same for the "Sneak Preview" :-(, that one now fails too.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske resolved JSPWIKI-348.
----------------------------------
Resolution: Won't Fix
Oke Lutz, thanks for the feedback.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske updated JSPWIKI-348:
---------------------------------
Attachment: JSPWIKI-348.patch
Thanks Lutz.
I created a (slightly modified) patch for the current trunk (2.7.0-alpha-23) and tested on Tomcat 5.5.17 on z/OS. (see attachment)
I plan to do some further testing on Tomcat/Linux and Glassfish/Linux.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-348.
------------------------------------
Resolution: Fixed
Patch brought in 2.8.1-svn-1. Sorry Harry, I was feeling bored :-)
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625247#action_12625247 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
Yes please, UtilJ2eeCompat looks like a good start for me.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske updated JSPWIKI-348:
---------------------------------
Priority: Minor (was: Major)
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623219#action_12623219 ]
Lutz Tietze commented on JSPWIKI-348:
-------------------------------------
Sorry for the inconveniences.
I know this was a quick and dirty fix. Just wanted the problem fixed and let you know just in case there might be another container showing the same strange behavior.
I am going to send you a better patch.
Regards
Lutz
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske resolved JSPWIKI-348.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.8.1)
2.8
Some minor changes to the patch, added Glassfish to the set, and an extra test.
Lutz, it would be nice if you could test this on an OC4J server .
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-348:
-----------------------------------
Fix Version/s: 2.8.1
Okka. Any objections in getting this into 2.8.1? (I'm trying to hold back on 2.8.0 features for now...)
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624819#action_12624819 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
Not good:
I have done some further testing (I'm also working on selenium tests a little), and it appears that with this patch applied the View Page Source fails, it just returns an empty page.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624653#action_12624653 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
Tests on Tomcat/Linux and Glassfish/Linux went fine, also the JUnit tests.
I don't who and why was decided to use a CharArrayWriter instead of a ByteArrayOutputStream, the latter seems more logical to me.
Can you test my latest patch, note that the most important change here (compared to your patch) is in the "public String toString()" method !
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-348:
-----------------------------------
Fix Version/s: (was: 2.6.3)
Removed fix version; please let the dev team assign the fix versions.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623189#action_12623189 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
Lutz,
thanks for reporting this issue and supplying the patch, although it is not required, it is nice when people also bring a cage with the monkey.
However, you supplied a patch for release 2.6, this is a stable release, and will not be fixed unless there are severe (security) issues.
So, is it possible to supply a patch for the latest release (2.7.0) ?
Also, it would be nice if you adhere to the coding standard that we use, see : http://www.jspwiki.org/wiki/JSPWikiCodingStandard
regards,
Harry
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Fix For: 2.6.3
>
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623207#action_12623207 ]
Janne Jalkanen commented on JSPWIKI-348:
----------------------------------------
Not only is the patch against our guidelines, I just don't get what the problem is: there are lines which are commented out, and it adds a whole new class without explaining what the problem really is. There are no comments in the patch either.
Unfortunately, until we understand the problem better, I don't think we can take this one in. It looks brittle to me (in the sense that it might break on other containers).
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627519#action_12627519 ]
Janne Jalkanen commented on JSPWIKI-348:
----------------------------------------
Thanks, this is looking better. BTW, what is the origin of the UtilJ2eeCompat class, and is it originally licensed under Apache copyright? Is the copyright notice on top of the file correct and also in the original?
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624080#action_12624080 ]
Lutz Tietze commented on JSPWIKI-348:
-------------------------------------
You probably didn't know what I meant with "chinese" characters. So, I uploaded some pictures.
After getting JSPWiki 2.6.3 to work on OC4J, finally - the main window appeared with those strange letters I have never seen before.
I entered some words in the edit mode. In view mode the umlauts were incorrectly converted, again. The files were saved OK.
There was no big difference whether I used UTF-8 or ISO-8859-1.
I logged the output coming from the WikiEngine. Everything seamed to be OK. Nothing wrong. The only thing which left was the WikiJSPFilter and the WikiServletFilter. After disabling the JSP Filter the output was correct.
I did some tests on a simple project with nothing but a JSP page and the WikiJSPFilter. I reduced the Filter so that it only wrapped the reponse and wrote it back to output stream. Bang.
After googling I found that Oracle recommends a different way of filtering the output than Sun. See http://web.deu.edu.tr/oracle/B25016_04/web/B14017_02/filters.htm
Hope this gives you an idea of the issue. The new patch or call it a workaround is supposed to be clearer and hopefully not breaking your guidelines anymore. I am going to test it on tomcat as soon as possible.
You wanted me to supply a patch for the 2.7.0 version. May be I am too stupid but I couldn't find this branche, tag?? The only newer version I saw was 2.8.0. I checked the souce code and did not find any major difference.
I would appreciate any comments.
Regards
Lutz
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: Edit.png, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-348:
-----------------------------------
Fix Version/s: (was: 2.8)
2.8.1
Correct Fix version.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628109#action_12628109 ]
Janne Jalkanen commented on JSPWIKI-348:
----------------------------------------
Since this has a potential of breaking pretty much everything, I think we should hold back the patch until 2.8.1... That is, once 2.8 is released, we'll commit it.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628113#action_12628113 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
what a timing :-(
2008/9/3 Janne Jalkanen (JIRA) <ji...@apache.org>
--
met vriendelijke groet,
Harry Metske
Telnr. +31-548-512395
Mobile +31-6-51898081
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625103#action_12625103 ]
Lutz Tietze commented on JSPWIKI-348:
-------------------------------------
I did some further testing and couldn't find a solution which worked for both, tomcat and oc4j.
Since oc4j is not a high priority I would not spent more effort on this issue.
The workaround is OK. View Page Source and Sneak View went fine on oc4j.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lutz Tietze updated JSPWIKI-348:
--------------------------------
Attachment: View.png
Edit.png
Main.png
JSPWiki 2.6.3 on OC4J 10.1.3.1
Pictures of the umlaut character issue
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: Edit.png, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623227#action_12623227 ]
Janne Jalkanen commented on JSPWIKI-348:
----------------------------------------
No prob, looking forward to it :-). It would be good to understand what exactly is going wrong; do you have some documentation to point at?
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske reopened JSPWIKI-348:
----------------------------------
I'm sorry, I did not read Janne's suggestion for 2.8.1 .
Reverted the modifications, delaying until 2.8.1
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625179#action_12625179 ]
Lutz Tietze commented on JSPWIKI-348:
-------------------------------------
_Someone_ has looked at it. :)
There is a org.ofbiz.base.util.UtilJ2eeCompat.java class in the Apache Open for Business Project which could be used to check what container is being used.
I would suggest putting the 2 different wrapper classes into separate files and check the container directly in the WikiJSPFilter class.
If this makes sense to you I would provide a patch.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641668#action_12641668 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
O no problem, I'm on a conference in the US the whole week, so I hardly have time.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lutz Tietze updated JSPWIKI-348:
--------------------------------
Attachment: UtilJ2eeCompatTest.java.patch
UtilJ2eeCompat.java.patch
WikiJSPFilter.java.patch
This is a simple solution for this issue only. The check of the container could also be used for other purposes.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen reopened JSPWIKI-348:
------------------------------------
I think we can still keep this open; someone could develop a patch which would dynamically detect OC4J and choose the right wrapper for those cases. Then it would be easy to take in, since it wouldn't break other containers. *wink, wink, nudge, nudge*
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, View.png
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lutz Tietze updated JSPWIKI-348:
--------------------------------
Attachment: JSPWiki-348.patch
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Fix For: 2.6.3
>
> Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-348) German umlauts not displayed properly
on OC4J installation
Posted by "Lutz Tietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lutz Tietze updated JSPWIKI-348:
--------------------------------
Attachment: JSPWiki-348.patch
Formatted
Cleaned up
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Attachments: JSPWiki-348.patch, JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-348) German umlauts not displayed
properly on OC4J installation
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627922#action_12627922 ]
Harry Metske commented on JSPWIKI-348:
--------------------------------------
No objections, but I was working on some minor adjustments for the patch.
I'd like to commit it in the next few days assuming the licensing is no problem.
> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
> Key: JSPWIKI-348
> URL: https://issues.apache.org/jira/browse/JSPWIKI-348
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
> Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
> Reporter: Lutz Tietze
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8.1
>
> Attachments: Edit.png, JSPWIKI-348.patch, JSPWiki-348.patch, JSPWiki-348.patch, Main.png, UtilJ2eeCompat.java.patch, UtilJ2eeCompatTest.java.patch, View.png, WikiJSPFilter.java.patch
>
>
> The German umlauts are shown as chinese (?) letters.
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. The conversion of the outputstream into a CharArrayWriter seams to be implemented differently on OC4J. The use of a ByteArrayOutputStream instead works for OC4J.
> Not tested on any other servlet container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.