You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Sorin Silaghi (JIRA)" <de...@myfaces.apache.org> on 2007/07/27 21:43:53 UTC
[jira] Created: (MYFACES-1688) Highlighting of component on error
page
Highlighting of component on error page
---------------------------------------
Key: MYFACES-1688
URL: https://issues.apache.org/jira/browse/MYFACES-1688
Project: MyFaces Core
Issue Type: Improvement
Components: General
Affects Versions: 1.1.6
Reporter: Sorin Silaghi
Priority: Trivial
The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1688) Highlighting of component on error
page
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Marinschek updated MYFACES-1688:
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.6-SNAPSHOT
Status: Resolved (was: Patch Available)
Thanks Sorin, excellent addition to MyFaces.
regards,
Martin
> Highlighting of component on error page
> ---------------------------------------
>
> Key: MYFACES-1688
> URL: https://issues.apache.org/jira/browse/MYFACES-1688
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6
> Reporter: Sorin Silaghi
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: 1.1.6-SNAPSHOT
>
> Attachments: error_handling-02-08.patch, sample-error.html
>
>
> The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1688) Highlighting of component on error
page
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516144 ]
Martin Marinschek commented on MYFACES-1688:
--------------------------------------------
Hi Sorin,
this is not enough, sorry. You'll need to go down the component tree and compare ids one by one to find to the correct component. There can be 10 components with the same id on a page in JSF - as an ID is only unique per naming container.
Additionally, I asked you to print the last exception in the stacktrace on top additionally to the first exception - so first, the message of the top exception, second the message of the bottom exception, then the full stacktrace.
regards,
Martin
> Highlighting of component on error page
> ---------------------------------------
>
> Key: MYFACES-1688
> URL: https://issues.apache.org/jira/browse/MYFACES-1688
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6
> Reporter: Sorin Silaghi
> Priority: Trivial
> Attachments: error_component_highlighting.patch
>
>
> The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1688) Highlighting of component on error
page
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517110 ]
Martin Marinschek commented on MYFACES-1688:
--------------------------------------------
Brilliant! I really love the results, plus played around a bit more - I'm using less static methods now (we could still clean this up a bit more, whenever someone gets time, plus also think about when/where synchronization might be necessary), and I also made sure that beans which are not there anymore are actually removed from session and application scope.
In any case, good work, Sorin - I love the effect for development - it will give us all a productivity boost.
regards,
Martin
> Highlighting of component on error page
> ---------------------------------------
>
> Key: MYFACES-1688
> URL: https://issues.apache.org/jira/browse/MYFACES-1688
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6
> Reporter: Sorin Silaghi
> Priority: Trivial
> Attachments: error_highlighting.patch, sample-error.html
>
>
> The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1688) Highlighting of component on error
page
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517114 ]
Martin Marinschek commented on MYFACES-1688:
--------------------------------------------
Hi Sorin,
very good - I like both the algorithm you used, and the outcome. Nice work!
Only thing - I can't apply the patch, as the file does seem to be out of date. Can you please recreate the patches?
Thanks,
regards,
Martin
> Highlighting of component on error page
> ---------------------------------------
>
> Key: MYFACES-1688
> URL: https://issues.apache.org/jira/browse/MYFACES-1688
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6
> Reporter: Sorin Silaghi
> Priority: Trivial
> Attachments: error_highlighting.patch, sample-error.html
>
>
> The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1688) Highlighting of component on error
page
Posted by "Sorin Silaghi (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sorin Silaghi updated MYFACES-1688:
-----------------------------------
Status: Patch Available (was: Open)
> Highlighting of component on error page
> ---------------------------------------
>
> Key: MYFACES-1688
> URL: https://issues.apache.org/jira/browse/MYFACES-1688
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6
> Reporter: Sorin Silaghi
> Priority: Trivial
>
> The patch just adds highlighting of the component that produced the error in the component tree
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.