You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (Created) (JIRA)" <ji...@apache.org> on 2012/04/06 02:50:21 UTC
[jira] [Created] (SOLR-3329) Use consistent svn:keywords
Use consistent svn:keywords
---------------------------
Key: SOLR-3329
URL: https://issues.apache.org/jira/browse/SOLR-3329
Project: Solr
Issue Type: Improvement
Reporter: Ryan McKinley
Fix For: 4.0
In solr, use use svn:keywords haphazardly
We have lots of places with:
{code}
svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
{code}
In LUCENE-3923, there is a suggestion to get rid of many of these.
The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3329) Use consistent svn:keywords
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247965#comment-13247965 ]
Chris Male commented on SOLR-3329:
----------------------------------
I agree with Yonik, I've never found this information useful. Why keep them?
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3329) Use consistent svn:keywords
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247921#comment-13247921 ]
Ryan McKinley commented on SOLR-3329:
-------------------------------------
In general, we need to decide what to do for SolrInfoMBean -- the current typical implemention is:
{code}
@Override
public String getVersion() {
return "$Revision: 1306018 $";
}
@Override
public String getSourceId() {
return "$Id: RealTimeGetComponent.java 1306018 2012-03-27 20:58:34Z yonik $";
}
@Override
public String getSource() {
return "$URL: https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java $";
}
{code}
but we often forget to set the svn:keyword property when adding new MBeans...
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3329) Use consistent svn:keywords
Posted by "Yonik Seeley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247956#comment-13247956 ]
Yonik Seeley commented on SOLR-3329:
------------------------------------
Honestly, I don't think I've ever found that extra info useful...
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3329) Don't use svn:properties Id or
Revision in SolrInfoMBean
Posted by "Ryan McKinley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-3329:
--------------------------------
Priority: Minor (was: Major)
Summary: Don't use svn:properties Id or Revision in SolrInfoMBean (was: Use consistent svn:keywords)
I'm changing the ticket name so it more accurately reflects the changes.
Robert.. we can look at the HeadURL issue in a different ticket. I think keeping the URL in the bean is useful -- perhaps we just need to remove the property from things that are not MBeans?
> Don't use svn:properties Id or Revision in SolrInfoMBean
> --------------------------------------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3329-svn-keywords.patch
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-3329) Use consistent
svn:keywords
Posted by "Chris Male (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247965#comment-13247965 ]
Chris Male edited comment on SOLR-3329 at 4/6/12 2:12 AM:
----------------------------------------------------------
I agree with Yonik, I've never found this information useful. +1 to Hoss's suggestion.
was (Author: cmale):
I agree with Yonik, I've never found this information useful. Why keep them?
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3329) Use consistent svn:keywords
Posted by "Ryan McKinley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-3329:
--------------------------------
Attachment: SOLR-3329-svn-keywords.patch
implements Chris's suggestion and removes "Date Author Id Revision" from most files
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3329-svn-keywords.patch
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3329) Use consistent svn:keywords
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247959#comment-13247959 ]
Hoss Man commented on SOLR-3329:
--------------------------------
These were all really designed originally for people writting plugins to be able to expose more information for their consumers about them that might not be obvious based on the global info about the Solr intall.
As for stuff in the solr source tree, i would suggest..
* getSource() - keep using $URL$, it doesn't really hurt anything.
* getVersion() - we should just start returning the implementaiton version from the package metadata
* getSourceId() - $Id$ is the most problematic svn keyword i've ever seen, lets just drop it and leave this blank in all the core mbeans ... plugin writers can use it however they want
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3329) Use consistent svn:keywords
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248284#comment-13248284 ]
Robert Muir commented on SOLR-3329:
-----------------------------------
{quote}
keep using $URL$, it doesn't really hurt anything.
{quote}
This still hurts when using ordinary patch/diff tools across different branches.
I frequently do this (I use patch --merge to merge outdated patches, and I use
diff to show changes including svn adds/deletes).
For example, i use the dev-tools/scripts/diffSources.py to review the differences
between a feature branch and trunk before merging it back.
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3329-svn-keywords.patch
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3329) Use consistent svn:keywords
Posted by "Ryan McKinley (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-3329.
---------------------------------
Resolution: Fixed
Assignee: Ryan McKinley
committed in #1310219
> Use consistent svn:keywords
> ---------------------------
>
> Key: SOLR-3329
> URL: https://issues.apache.org/jira/browse/SOLR-3329
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3329-svn-keywords.patch
>
>
> In solr, use use svn:keywords haphazardly
> We have lots of places with:
> {code}
> svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
> {code}
> In LUCENE-3923, there is a suggestion to get rid of many of these.
> The MBeans interface often exposes HeadURL, but we likely want to get rid of the rest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org