You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org> on 2010/05/18 15:49:42 UTC
[jira] Created: (BUILDR-436) release task should only raplce
"-SNAPSHOT"
release task should only raplce "-SNAPSHOT"
-------------------------------------------
Key: BUILDR-436
URL: https://issues.apache.org/jira/browse/BUILDR-436
Project: Buildr
Issue Type: Bug
Components: Packaging
Affects Versions: 1.3.5
Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
Reporter: Jean-Philippe Caruana
When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868662#action_12868662 ]
Antoine Toulme commented on BUILDR-436:
---------------------------------------
Actually, if you want an increment, then you need the -SNAPSHOT.
2.2.0-rc1-SNAPSHOT will do the increment.
Otherwise the expected value should be "-rc1"
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Attachments: spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-436.
-----------------------------------
Assignee: Antoine Toulme
Resolution: Fixed
Fixed, thanks Jean-Philippe for the spec!
23:10:15~/w/buildr>svn ci spec/core/build_spec.rb lib/buildr/core/build.rb CHANGELOG -m "fix for BUILDR-436 release task should only replace '-SNAPSHOT'"
Sending CHANGELOG
Sending lib/buildr/core/build.rb
Sending spec/core/build_spec.rb
Transmitting file data ...
Committed revision 962424.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only raplce
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Attachment: spec.patch
I hope this patch will be okay : it shows the bug, but my expected value ("-rc2") may not be what we want to do.
> release task should only raplce "-SNAPSHOT"
> -------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Attachments: spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-436.
-----------------------------------
Resolution: Fixed
00:19:52~/w/buildr>svn ci spec/core/build_spec.rb lib/buildr/core/build.rb -m "better fix for BUILDR-436"
Sending lib/buildr/core/build.rb
Sending spec/core/build_spec.rb
Transmitting file data ..
Committed revision 964700.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Affects Version/s: 1.4
Fix Version/s: Wish List
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Fix For: Wish List
>
> Attachments: spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme reopened BUILDR-436:
-----------------------------------
Reopening.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Attachment: BUILDR-436_spec.patch
changed spec patch (now named BUILDR-436_spec.patch)
thanks Antoine
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Fix For: Wish List
>
> Attachments: BUILDR-436_spec.patch, spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889050#action_12889050 ]
Hudson commented on BUILDR-436:
-------------------------------
Integrated in Buildr-ci-build #65 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/65/])
better fix for BUILDR-436
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886637#action_12886637 ]
Hudson commented on BUILDR-436:
-------------------------------
Integrated in Buildr-ci-build #57 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/57/])
fix for BUILDR-436 release task should only replace '-SNAPSHOT'
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Fix Version/s: 1.4.2
(was: Wish List)
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890585#action_12890585 ]
Jean-Philippe Caruana commented on BUILDR-436:
----------------------------------------------
great ! thanks !
I will try it asap
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868668#action_12868668 ]
Jean-Philippe Caruana commented on BUILDR-436:
----------------------------------------------
"we will let people implement strategies" (see http://buildr.markmail.org/search/list:users#query:list%3Ausers+page:1+mid:s4bnewyp53f2faes+state:results)
I don't know what the expected value should be.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Fix For: Wish List
>
> Attachments: spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889036#action_12889036 ]
Antoine Toulme commented on BUILDR-436:
---------------------------------------
The specs actually run with GitRelease and SvnRelease, but everything is stubbed.
I added a spec to make sure no commit is asked if the version didn't change.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Summary: release task should only replace "-SNAPSHOT" (was: release task should only raplce "-SNAPSHOT")
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Attachments: spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888695#action_12888695 ]
Alexis Midon commented on BUILDR-436:
-------------------------------------
This issue should be reopen. The patch does not work.
The patch intent is to not increment the version number when there's no SNAPSHOT, in which case the buildfile is left untouched.
But the next step in the release process is to commit the buildfile which fails because there's no change.
The specs didn't detect the bug because they only use the parent class Release, not GitRelease or SvnRelease.
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-436) release task should only replace
"-SNAPSHOT"
Posted by "Jean-Philippe Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Philippe Caruana updated BUILDR-436:
-----------------------------------------
Attachment: (was: spec.patch)
> release task should only replace "-SNAPSHOT"
> --------------------------------------------
>
> Key: BUILDR-436
> URL: https://issues.apache.org/jira/browse/BUILDR-436
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Environment: Linux 2 2.6.31-21-generic i686 GNU/Linux
> Reporter: Jean-Philippe Caruana
> Fix For: Wish List
>
> Attachments: BUILDR-436_spec.patch
>
>
> When I commit "2.2.0-rc1" in my buildfile and do a "buildr release", it builds a project-artifact-2.2.0.jar. My "-rc1" is dropped (everything after "-" is dropped, in order to drop the "-SNAPSHOT" part)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.