You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/08/26 11:02:09 UTC
[PR] ci(ruff): reformat Python snippets in three skill markdown files [magpie]
potiuk opened a new pull request, #1117:
URL: https://github.com/apache/magpie/pull/1117
## Summary
- `ruff format --check` currently fails on `main`, which breaks the required
`prek` status on every open PR — including unrelated ones (spotted on #1116,
an `.asf.yaml`-only change).
- Three fenced ```python blocks inside skill docs predate the ruff 0.16.1
bump in 5b504d85 and no longer match the formatter:
`skills/contributor-nomination/fetch.md:202`,
`skills/contributor-sentiment/SKILL.md:217`,
`skills/issue-reproducer/verification.md:60`.
- This applies exactly what `ruff format` produces and nothing else: comment
gaps normalised to two spaces, binary operators spaced, and a blank line
after an `import re`. No snippet changes behaviour or meaning.
## Type of change
- [x] CI / dev loop (`prek`, workflows, validators)
## Test plan
- [x] `uv run ruff format --check skills/` → `143 files already formatted`
- [x] `prek run --files <the three files>` passes every applicable hook
(markdownlint, lychee, check-placeholders, skill-and-tool-validate included)
- Diff is formatter output only; no skill behaviour is touched, so no eval
fixture changes apply.
## RFC-AI-0004 compliance
Not applicable — whitespace-only changes to documentation snippets.
## Linked issues
Refs #1116 (blocked by this failure).
## Notes for reviewers
In `issue-reproducer/verification.md` the reformatted "Bad" Python block now
sits next to an unchanged Java block that still uses wide comment alignment —
ruff doesn't touch Java. The visual asymmetry is cosmetic; aligning the Java
snippet by hand seemed worse than leaving the formatter as the single source
of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(ruff): reformat Python snippets in three skill markdown files [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1117:
URL: https://github.com/apache/magpie/pull/1117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org